Check if ENV HTTP_X_FORWARDED_HOST is available before using it#930
Closed
melo wants to merge 1 commit intoPerlDancer:masterfrom
Closed
Check if ENV HTTP_X_FORWARDED_HOST is available before using it#930melo wants to merge 1 commit intoPerlDancer:masterfrom
melo wants to merge 1 commit intoPerlDancer:masterfrom
Conversation
Member
There was a problem hiding this comment.
probably use exists instead of autovivificating it?
Member
|
👍 |
Contributor
|
The problem with this is that if the header is missing (i.e. the client sent a HTTP/1.0 header without host), then the internal host name is returned in I would have thought it would be better returning an empty string in these circumstances, which I presume is the behaviour you would get if you were not running behind a proxy and the client sent no host header. |
Contributor
|
See #935. |
xsawyerx
added a commit
that referenced
this pull request
Jul 8, 2015
[ BUG FIXES ]
* GH #915, #930: Check existence of optional extension headers when
behind proxy. (Andy Beverley, Pedro Melo, Russell Jenkins)
* GH #926, #940: Set session directory default to $apprdir/session.
(Russell Jenkins)
* GH #936, #939: Use the error_template configuration on a 404.
(Russell Jenkins)
* GH #844, #937: Non-hash serialized params do not cause a crash. (Sawyer X)
* GH #943: Pass @_ to UNIVERSAL's VERSION so it validates version number.
(Sawyer X)
* GH #934: Cleanup internals in the old Dispatcher. (Russell Jenkins)
[ DOCUMENTATION ]
* Sanitize Changes
* GH #938: Fix POD link to params keyword. (Ludovic Tolhurst-Cleaver)
* GH #935: Provide more details and considerations when using
behind_proxy. (Andy Beverley)
[ ENHANCEMENT ]
* GH #933: use note in tests to produce cleaner non-verbose output (Vernon)
* Remove unnecessary dependencies: build chain should be smaller. (Sawyer X)
* No need for Module::Build. (Sawyer X)
* GH #911: Dancer2 request object is now a subclass of Plack::Request.
It's also much faster now. (Sawyer X)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.