Library refactoring #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mipmap folder should only be used for app icons
Simplifies layouts while maintaining how they look Adds String resource for hash sign Replaces deprecated singleLine Fixes private property call for text colour
Simplifies every method by removing many unnecessary condition constructs Adds helper methods -- including tests -- for left-padding and color value setting Adds IntRange annotations so that Android Studio shows warnings if wrong values are input when using the library.
|
Thank you so much! The project needed a huge refactoring ^_^ |
|
Sure! :) Will you make sure that the new version 1.0.5 gets deployed to Bintray? |
|
Sure, I'll upload it this afternoon because now I'm not on my pc :)
Il 04 mar 2017 11:24, "Patrick Geselbracht" <notifications@github.com> ha
scritto:
… Sure! :)
Will you make sure that the new version 1.0.5 gets deployed to Bintray?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACxXwD5y6U3BtwGeo4o_cpBTIV0dJcraks5riTvlgaJpZM4MSlBx>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of the whole library
See commit messages for a list of changes