Skip to content

Conversation

@PattaFeuFeu
Copy link

  • Adds optional alpha value slider
  • Adds custom SeekBar view that shows the progress as a label text floating above
  • Deprecates OnColorSelected callback, adds new, renamed callback interface
  • Adds new screenshots including alpha value sliders
  • Updates Readme.md accordingly

@Pes8
Copy link
Owner

Pes8 commented Mar 5, 2017

Thank you @PattaFeuFeu for all the improvements :) Only one thing: I'm not sure it's a good idea to broke the compatibilty with the old callback :/ Maybe we can set it as deprecated but also call it ? Anyway I'll merge it and tomorrow I'll upload it to bintray :)

@Pes8 Pes8 merged commit 37220ae into Pes8:master Mar 5, 2017
@PattaFeuFeu
Copy link
Author

I wasn’t sure either but in the end decided that it’d be OK—I marked the interface as well as the method as deprecated, changed the version number from 1.0.* to 1.1.* so that everyone who currently has gradle set to download anything after 1.0.* wouldn’t be affected by those breaking changes, and added the paragraph in the Readme, although to be fair I guess nobody will read that. 😆

@PattaFeuFeu PattaFeuFeu deleted the feature/alpha branch March 5, 2017 19:28
@Pes8
Copy link
Owner

Pes8 commented Mar 6, 2017

Yeah, that's the point :D Nobody will read the Readme :D Well, I think its OK. I'll upload the new version.

PS: thank you very much, next time add your credits to the readme (if you want). Maybe we can make a "contributors" section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants