Anim Create unit #193
Merged
Anim Create unit #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nightly build for this pull request:
|
Otamaa
force-pushed
the
feature/AnimToUnit
branch
from
cf19674 to
61d8353
Compare
|
666 good decompiler |
Otamaa
added a commit
to Otamaa/Phobos
that referenced
this pull request
May 5, 2021
* Implementing RadType Enumeration * Bug fix Multiple RadSite on same area causing inf play mutiple death animation/generating multiple UnitToInf * New Instances without Rely on Wepon experimental stuffs , it breaks Inf_AIDeploy_Check rad fix * Attempt to fix some known vanilla bugs -Deso cannot fire his weapon when cloaked (partialy fixed) -Unit with Death Weapon able to die twices (not affect yet) * Re-Cloak Deso when Undeployed -Deso cannot fire his Deploy weapon when cloaked (fixed) * Further changes * Removing unnessesary codes , fix some style , Doc * Refactorings Co-authored-by: Meta (X230T) <crabiter@vivaldi.net> Force C4Warhead PenetratesShield Fix shield SL issue Small refactor; version bump Change the check back to vanilla implement AnimList.PickRandom use ternary operator update for AnimList.PickRandom update code style Fix magnetron issue Phobos-developers#195 (Phobos-developers#200) Fix ranged mc desync (Phobos-developers#199) * Attempt to fix desync * Remove the check for player A pair of braces Bump version Remove `the Forgotten` Separate HP and cloak check of shield anim Fix lost HP check Contributing guidelines started; Git branching model info Skip the low damage check when techno has shield STUPID WW!!!!! closes Phobos-developers#204 First iteration of the styleguide
Otamaa
added a commit
to Otamaa/Phobos
that referenced
this pull request
May 5, 2021
Belonit
force-pushed
the
develop
branch
2 times, most recently
from
ea3320f to
6d739d5
Compare
Otamaa
force-pushed
the
feature/AnimToUnit
branch
from
c0b1869 to
a951deb
Compare
Metadorius
force-pushed
the
feature/AnimToUnit
branch
from
a951deb to
302a1ae
Compare
Co-authored-by: Otamaa <otamaindodapuq2@gmail.com>
-Add AnimExt -Add hook for UnitClass_TakeDamage -Add some more misc function -Calculate DestroyAnim index to be used on Unit Source Facings and DestroyAnim count -Remove ability to create unit on air and some tags , due to bug(s) -No proper Doc's Yet !
Thrifinesma
force-pushed
the
develop
branch
3 times, most recently
from
93a2e8b to
c43f8e8
Compare
Otamaa
force-pushed
the
feature/AnimToUnit
branch
from
af20fbe to
50eea51
Compare
-Receivedamageargs.HouseSource giving corrupt data causing crash
Otamaa
force-pushed
the
feature/AnimToUnit
branch
from
50eea51 to
d7847d8
Compare
-Change it to DTOR (Hopefully no issue this time)
Otamaa
force-pushed
the
feature/AnimToUnit
branch
from
f83f4bc to
c271e17
Compare
Metadorius
requested changes
Jul 30, 2021
Member
Metadorius
left a comment
Metadorius
left a comment
There was a problem hiding this comment.
Work's good, we can merge this after addressing some concerns.
Comment on lines
75
to
77
| int aFacing = pTypeExt->CreateUnit_Facing.Get(); | ||
| aFacing = aFacing > 255 ? 255 : aFacing; | ||
| aFacing = aFacing <= -1 ? ScenarioClass::Instance->Random.RandomRanged(0, 255) : aFacing; |
Member
There was a problem hiding this comment.
This code can be simplified if we introduce a separate tag to control whether the facing is random.
src/Ext/AnimType/Body.h
Outdated
Comment on lines
20
to
21
| Valueable<bool> CreateUnit_UseDeathFacings; | ||
| Valueable<bool> CreateUnit_UseDeathTurretFacings; |
Member
There was a problem hiding this comment.
Does splitting this into two tags have some use? I feel like we should squash those tags into one and name it CreateUnit.InheritFacings.
-Add `unsigned short` for TemplateDef.h -UseDeathFacings -> InheritFacings -UseTurretDeathFacings-> inheritTurretFacings
Metadorius
approved these changes
Jul 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anim Create Unit
https://i.imgur.com/Stnz6Vu.gif
Animationusually had noOwnerwill create unit withCivilianOwnerinsted. https://i.imgur.com/0Ox6zGN.gif-Using Unit
DestroyAnimis mostly recomended since it got rewritten for this purpose.In
rulesmd.ini:In
artmd.ini:##Note :
CreateUnit.Owneris only applicable whenSource Unitis killed byTake Damagefunction of the game.Turrent Facingreset come on separate feature