"Download runtime json..." displayed as default message while installing a script

[ImperatorS79]

See #959 at the end.

[plata]

The installation enters _installRuntime several times. Is this intended?

[ImperatorS79]

It should only do that when installing a wine package in install. I expected it was only called once.

[plata]

You can add a print out. It's called several times (of course the runtime is downloaded only once).

[plata]

This is a way more general issue: We want to control the wait message during wine.run. However, wine.run itself changes the wait message if e.g. Wine or the runtime is installed and cannot recover the initial wait message.
@qparis do you think it would make sense to have something like wizard.currentWaitMessage?

[qparis]

I would rather implement the wait message feature on the wine object imho

[madoar]

Just as a reminder/info: I'm planning to merge wine object and wine implementation over the next few days.

[plata]

@qparis can you elaborate?

[Zemogiter]

I confirm this still being the issue using the latest script repo and POL5 commit PhoenicisOrg/phoenicis@f69f24f

[plata]

I'm still not really sure how the solution proposed by @qparis could look like. Nevertheless, I don't think it makes sense to check the runtime json multiple times during one installation. Therefore I would propose to add a new member _fetchedRuntimeJson to WineEngine which is set to true the first time the json is downloaded. If it is true, do not download it again in:

scripts/Engines/Wine/Engine/Implementation/script.js

Line 149 in 773a6dd

} else {

[ImperatorS79]

I do not even understand why the method is called multiple times. You do not need a new method. Just move _installRuntime to a location where it is executed only once. And I do not see how it will solve the "bug" mentionned in the title..

[plata]

The problem is: where is that location?

[ImperatorS79]

@plata Here: https://github.com/PhoenicisOrg/scripts/blob/master/Engines/Wine/Engine/Implementation/script.js, this.install() is called once line 360 and once line 407. The second one seems superfluous since we return if we cannot execute the first one.

[plata]

I don't think that's correct. If the second one is removed, you will not be able to change the Wine version for an existing prefix (iirc).

[ImperatorS79]

If you look closely, if the first one is not called, the second one is not either (there is a return in the else).

The change of wine version in an existing prefix is done in the changeVersion method.