Skip to content

Conversation

plata
Copy link
Collaborator

@plata plata commented Sep 11, 2019

It is sufficient to download/update the runtime once during one installation. We can safely assume that the runtime does not change during this period of time.

fixes #1055

@ImperatorS79 ImperatorS79 merged commit 9e50acf into master Sep 11, 2019
@madoar
Copy link
Collaborator

madoar commented Sep 11, 2019

I'm not a fan of this solution. It looks like a hack to me. I think a better approach is to check whether the runtime folder exists. If it does we should perform some validation (checksum? file counting?). If the folder is valid we skip the runtime installation, if not we replace/download it.

@ImperatorS79
Copy link
Contributor

You always have to fetch the json from internet to check if the runtime has been updated. This PR just avoids that if the runtime json have already been fetched in one installation it is not fetched again during this installation.

@madoar
Copy link
Collaborator

madoar commented Sep 11, 2019

I understand that but still in theory we require only one mechanism that can be used in all situations.

@ImperatorS79
Copy link
Contributor

I do not understand what you mean here.

@madoar
Copy link
Collaborator

madoar commented Sep 11, 2019

We can use the approach I described above in all situations, independent of whether we are calling the same method multiple times during one installation or across multiple installations. We don't need a second "fallback" solution.

@ImperatorS79
Copy link
Contributor

I still do not understand why what has been done is a hack. We do not have the checksum of each file inside the runtime, and it would be insane to check everything.

@plata plata deleted the install-runtime-once branch September 12, 2019 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Download runtime json..." displayed as default message while installing a script
3 participants