Update Space Engineers, bumped up wine version and fixed few typos #1110
Conversation
| .author("Zemogiter") | ||
| .appId(244850) | ||
| .wineVersion("4.11") | ||
| .appId("244850") |
There was a problem hiding this comment.
@plata should the appId be passed as a string or as a number?
There was a problem hiding this comment.
I don't think so but I think we should do it in a uniform manner.
There was a problem hiding this comment.
Isn't it uniform in the other Steam scripts?
There was a problem hiding this comment.
According to other scripts appId should be a number, see:
Maybe we should enforce this and throw an error if some invalid input has been given?
There was a problem hiding this comment.
When installing Space Engineers I get the same error from #1098 (comment)
There was a problem hiding this comment.
Changing appId back to number changes nothing. Still getting that error.
There was a problem hiding this comment.
@Zemogiter I think you misunderstand the comment discussions. This is not about the error you are getting. We simply want to have a uniform style how the appId should be passed to the SteamScript.
There was a problem hiding this comment.
@madoar understood
Description
It should be
no-cef-sandboxnotno-ces-sandboxWhat works
Everything but sometimes Wine decides to force ALSA instead of PulseAudio. This results in even choppier audio. But when I use winetricks to set it to pulse and go to the sound tab in winecfg I get "none" next to the "chosen driver".
What was not tested
Nothing I can think of at this moment
Test
i7-7700K, GTX 1080 ti
Ready for review
json-alignandeslintrun according to the documentation.