Skip to content

Update Space Engineers, bumped up wine version and fixed few typos #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2019
Merged

Update Space Engineers, bumped up wine version and fixed few typos #1110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Applications/Games/Space Engineers/Steam/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ new SteamScript()
.name("Space Engineers")
.editor("Keen Software House")
.author("Zemogiter")
.appId(244850)
.wineVersion("4.11")
.appId("244850")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@plata should the appId be passed as a string or as a number?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it matter?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so but I think we should do it in a uniform manner.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it uniform in the other Steam scripts?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to other scripts appId should be a number, see:

scripts/Applications/Games/Enderal/Steam/script.js

Line 8 in 920c415

.appId(72850) // Skyrim appId

scripts/Applications/Games/BRINK/Steam/script.js

Line 7 in 920c415

.appId(22350);

scripts/Applications/Games/BioShock/Steam/script.js

Line 7 in 920c415

.appId(7670);

Maybe we should enforce this and throw an error if some invalid input has been given?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When installing Space Engineers I get the same error from #1098 (comment)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be number.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing appId back to number changes nothing. Still getting that error.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zemogiter I think you misunderstand the comment discussions. This is not about the error you are getting. We simply want to have a uniform style how the appId should be passed to the SteamScript.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@madoar understood

.wineVersion("4.14")
.wineDistribution("upstream")
.wineArchitecture("amd64")
.preInstall(function (wine, wizard) {
Expand All @@ -24,4 +24,4 @@ new SteamScript()
wizard.message(tr("You have to install libjpeg62 and libjpeg62-dev or else the thumbnails in New Game menu will be dispalyed as magenta rectangles."));
wizard.message(tr("Due to JIT compiler issues and the way this game uses multithreating, there are audio stutters. This script will attempt to minimize them but you might also have to enter the alsoft-conf command in terminal and set sample depth to 32bit float and period size to 2048."));
})
.executable("Steam.exe", ["-silent", "-applaunch", 244850, "-no-ces-sandbox", "-skipintro"])
.executable("Steam.exe", ["-silent", "-applaunch", "244850", "-no-cef-sandbox", "-skipintro"])