Skip to content

Commit 352a885

Browse files
authored
🐛 Fix(plugin-handler): add optional env param for uninstall method (#194)
1 parent a27f5a4 commit 352a885

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/lib/PluginHandler.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,13 +101,13 @@ export class PluginHandler implements IPluginHandler {
101101
}
102102
}
103103

104-
async uninstall (plugins: string[]): Promise<IPluginHandlerResult<boolean>> {
104+
async uninstall (plugins: string[], env?: IProcessEnv): Promise<IPluginHandlerResult<boolean>> {
105105
const processPlugins = plugins.map((item: string) => handlePluginNameProcess(this.ctx, item)).filter(item => item.success)
106106
const pkgNameList = processPlugins.map(item => item.pkgName)
107107
if (pkgNameList.length > 0) {
108108
// uninstall plugins must use pkgNameList:
109109
// npm uninstall will use the package.json's name
110-
const result = await this.execCommand('uninstall', pkgNameList, this.ctx.baseDir)
110+
const result = await this.execCommand('uninstall', pkgNameList, this.ctx.baseDir, undefined, env)
111111
if (!result.code) {
112112
pkgNameList.forEach((pluginName: string) => {
113113
this.ctx.pluginLoader.unregisterPlugin(pluginName)

src/types/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -559,7 +559,7 @@ export interface IPluginProcessResult {
559559
export interface IPluginHandler {
560560
install: (plugins: string[], options: IPluginHandlerOptions, env?: IProcessEnv) => Promise<IPluginHandlerResult<boolean>>
561561
update: (plugins: string[], options: IPluginHandlerOptions, env?: IProcessEnv) => Promise<IPluginHandlerResult<boolean>>
562-
uninstall: (plugins: string[]) => Promise<IPluginHandlerResult<boolean>>
562+
uninstall: (plugins: string[], env?: IProcessEnv) => Promise<IPluginHandlerResult<boolean>>
563563
}
564564

565565
export interface IPluginHandlerResult<T> {

0 commit comments

Comments
 (0)