Skip to content

Commit 1eb89ce

Browse files
PlumezzPlumezz
authored
Update linters for generate_parameter_library_external (#270)
1 parent 3d15bfd commit 1eb89ce

File tree

3 files changed

+63
-41
lines changed

3 files changed

+63
-41
lines changed

‎example_external/CMakeLists.txt‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,4 +49,13 @@ install(
4949

5050
ament_export_targets(export_generate_parameter_library_example_external HAS_LIBRARY_TARGET)
5151
ament_export_dependencies(rclcpp rclcpp_components generate_parameter_library_example)
52+
53+
if(BUILD_TESTING)
54+
find_package(ament_lint_auto REQUIRED)
55+
set(ament_cmake_cpplint_FOUND TRUE) # Conflicts with clang-foramt
56+
set(ament_cmake_flake8_FOUND TRUE) # Conflicts with black
57+
set(ament_cmake_uncrustify_FOUND TRUE) # Conflicts with clang-format
58+
ament_lint_auto_find_test_dependencies()
59+
endif()
60+
5261
ament_package()

‎example_external/include/generate_parameter_library_example_external/minimal_publisher_external.hpp‎

Lines changed: 29 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,40 @@
11
// Copyright 2025 Forssea Robotics
22
//
3-
// Redistribution and use in source and binary forms, with or without
4-
// modification, are permitted provided that the following conditions are met:
3+
// All rights reserved.
54
//
6-
// * Redistributions of source code must retain the above copyright
7-
// notice, this list of conditions and the following disclaimer.
5+
// Software License Agreement (BSD License 2.0)
86
//
9-
// * Redistributions in binary form must reproduce the above copyright
10-
// notice, this list of conditions and the following disclaimer in the
11-
// documentation and/or other materials provided with the distribution.
7+
// Redistribution and use in source and binary forms, with or without
8+
// modification, are permitted provided that the following conditions
9+
// are met:
1210
//
13-
// * Neither the name of Forssea Robotics nor the names of its
14-
// contributors may be used to endorse or promote products derived from
15-
// this software without specific prior written permission.
11+
// * Redistributions of source code must retain the above copyright
12+
// notice, this list of conditions and the following disclaimer.
13+
// * Redistributions in binary form must reproduce the above
14+
// copyright notice, this list of conditions and the following
15+
// disclaimer in the documentation and/or other materials provided
16+
// with the distribution.
17+
// * Neither the name of the Forssea Robotics nor the names of its
18+
// contributors may be used to endorse or promote products derived
19+
// from this software without specific prior written permission.
1620
//
17-
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
18-
// AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
19-
// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
20-
// ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
21-
// LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
22-
// CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
23-
// SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
24-
// INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
25-
// CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
26-
// ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
21+
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
22+
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
23+
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
24+
// FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
25+
// COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
26+
// INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
27+
// BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
28+
// LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
29+
// CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
30+
// LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
31+
// ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
2732
// POSSIBILITY OF SUCH DAMAGE.
2833

2934
#pragma once
3035

36+
#include <memory>
37+
3138
#include <rclcpp/rclcpp.hpp>
3239
#include <rclcpp_components/register_node_macro.hpp>
3340

@@ -37,7 +44,8 @@ namespace admittance_controller {
3744

3845
class MinimalPublisher : public rclcpp::Node {
3946
public:
40-
MinimalPublisher(const rclcpp::NodeOptions& options = rclcpp::NodeOptions());
47+
explicit MinimalPublisher(
48+
const rclcpp::NodeOptions& options = rclcpp::NodeOptions());
4149

4250
private:
4351
void timer_callback();

‎example_external/src/minimal_publisher_external.cpp‎

Lines changed: 25 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,34 @@
11
// Copyright 2025 Forssea Robotics
22
//
3-
// Redistribution and use in source and binary forms, with or without
4-
// modification, are permitted provided that the following conditions are met:
3+
// All rights reserved.
54
//
6-
// * Redistributions of source code must retain the above copyright
7-
// notice, this list of conditions and the following disclaimer.
5+
// Software License Agreement (BSD License 2.0)
86
//
9-
// * Redistributions in binary form must reproduce the above copyright
10-
// notice, this list of conditions and the following disclaimer in the
11-
// documentation and/or other materials provided with the distribution.
7+
// Redistribution and use in source and binary forms, with or without
8+
// modification, are permitted provided that the following conditions
9+
// are met:
1210
//
13-
// * Neither the name of Forssea Robotics nor the names of its
14-
// contributors may be used to endorse or promote products derived from
15-
// this software without specific prior written permission.
11+
// * Redistributions of source code must retain the above copyright
12+
// notice, this list of conditions and the following disclaimer.
13+
// * Redistributions in binary form must reproduce the above
14+
// copyright notice, this list of conditions and the following
15+
// disclaimer in the documentation and/or other materials provided
16+
// with the distribution.
17+
// * Neither the name of the Forssea Robotics nor the names of its
18+
// contributors may be used to endorse or promote products derived
19+
// from this software without specific prior written permission.
1620
//
17-
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
18-
// AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
19-
// IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
20-
// ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
21-
// LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
22-
// CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
23-
// SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
24-
// INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
25-
// CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
26-
// ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
21+
// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
22+
// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
23+
// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
24+
// FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
25+
// COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
26+
// INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
27+
// BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
28+
// LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
29+
// CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
30+
// LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
31+
// ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
2732
// POSSIBILITY OF SUCH DAMAGE.
2833

2934
#include "generate_parameter_library_example_external/minimal_publisher_external.hpp"

0 commit comments

Comments
 (0)