Skip to content

Conversation

@Plumezz
Copy link
Contributor

@Plumezz Plumezz commented Jul 17, 2025

add some lint tools

@christophfroehlich
Copy link
Collaborator

Looks good, please also fix the linter errors now.

@Plumezz
Copy link
Contributor Author

Plumezz commented Jul 17, 2025

Sorry, I just fixed the cppllint errors. Now I have no idea about the copyright error,

@christophfroehlich
Copy link
Collaborator

It is missing the license type in the copyright claim
https://github.com/PickNikRobotics/generate_parameter_library/blob/main/example_external/src/minimal_publisher_external.cpp#L1
as the repo has BSD-3-Clause license, just add the missing lines like from here.

@Plumezz
Copy link
Contributor Author

Plumezz commented Jul 17, 2025

Ok, I tried to fix it.

@christophfroehlich
Copy link
Collaborator

Have you ran the tests locally? (pre-commit and colcon test?)

@Plumezz
Copy link
Contributor Author

Plumezz commented Jul 17, 2025

Sorry, I modified files in the original directory without adding lint tools. So there is no error in the output of command colcon test and I commit the changed files. Now I run colcon test again, it has the same lint copyright erroos.

Sorry for my careless PR.

Copy link
Collaborator

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi @Plumezz: I but changed it to have the same setup as the generate_parameter_library_example package. For green CI, I had to fix the pre-commit job by running pre-commit run --all, and the failing ament_copyright job by updating the license claim.

@christophfroehlich christophfroehlich merged commit 1eb89ce into PickNikRobotics:main Nov 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redundant test dependencies in package.xml of generate_parameter_library_example_external

2 participants