-
Notifications
You must be signed in to change notification settings - Fork 62
add some lint tools #270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add some lint tools #270
Conversation
|
Looks good, please also fix the linter errors now. |
|
Sorry, I just fixed the cppllint errors. Now I have no idea about the copyright error, |
|
It is missing the license type in the copyright claim |
|
Ok, I tried to fix it. |
|
Have you ran the tests locally? ( |
|
Sorry, I modified files in the original directory without adding lint tools. So there is no error in the output of command Sorry for my careless PR. |
5b90834 to
ea6d1b3
Compare
christophfroehlich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi @Plumezz: I but changed it to have the same setup as the generate_parameter_library_example package. For green CI, I had to fix the pre-commit job by running pre-commit run --all, and the failing ament_copyright job by updating the license claim.
add some lint tools