Skip to content

Migrate from parameter_traits to RSL (take 2) #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 14, 2022
Merged

Migrate from parameter_traits to RSL (take 2) #91

merged 7 commits into from
Nov 14, 2022

Conversation

@tylerjw
Copy link
Contributor

@tylerjw tylerjw commented Nov 12, 2022

No description provided.

@tylerjw
Copy link
Contributor Author

tylerjw commented Nov 12, 2022 •
edited
Loading

error: no matching function for call to ‘rclcpp::ParameterValue::ParameterValue(rsl::StaticString<25>&)’

  • convert static strings and vectors into parameter value types using function

tylerjw and others added 2 commits November 14, 2022 11:36
@tylerjw tylerjw force-pushed the to_rsl_validation branch 3 times, most recently from 5852a96 to 9f100d8 Compare November 14, 2022 18:47
@tylerjw tylerjw marked this pull request as ready for review November 14, 2022 18:47
@tylerjw
delete unused
e2eb418 
Signed-off-by: Tyler Weaver <tyler@picknik.ai>
@tylerjw tylerjw merged commit 44b5576 into main Nov 14, 2022
@delete-merged-branch delete-merged-branch bot deleted the to_rsl_validation branch November 14, 2022 22:37
@youtalk youtalk mentioned this pull request Nov 5, 2025
Open
3 tasks
This was referenced Nov 21, 2025
Merged
Merged
This was referenced Nov 21, 2025
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ChrisThrasher ChrisThrasher ChrisThrasher approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tylerjw @ChrisThrasher