Skip to content

Switch to moveit_ci, apply clang-format #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 20, 2019
Merged

Switch to moveit_ci, apply clang-format #124

merged 3 commits into from
Aug 20, 2019

Conversation

davetcoleman
Copy link
Member

This repo was using a bad CI approach and not using our best practices

@auto-assign auto-assign bot requested a review from henningkayser August 14, 2019 00:05
henningkayser
henningkayser reviewed Aug 15, 2019
View reviewed changes
Copy link
Contributor

@henningkayser henningkayser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, now we have to fix clang-tidy ;)

@davetcoleman
Copy link
Member Author

There are a lot of clang-tidy errors, which I do not have time for :-/
I think this PR will just stay open until someone is able to address this...

@davetcoleman
Copy link
Member Author

I've actually just removed the clang-tidy tests so we can merge this in now...

@davetcoleman davetcoleman mentioned this pull request Aug 20, 2019
Closed
nbbrooks
nbbrooks approved these changes Aug 20, 2019
View reviewed changes
Copy link
Member

@nbbrooks nbbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool. The clang tidy cleanup sounds like a great project for Jafer / Guilherme!

@davetcoleman davetcoleman merged commit b454935 into master Aug 20, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix_clang_format_travis branch August 20, 2019 23:44
@davetcoleman
Copy link
Member Author

I've added to JIRA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbrooks nbbrooks nbbrooks approved these changes

+1 more reviewer

@henningkayser henningkayser henningkayser left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@nbbrooks nbbrooks

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davetcoleman @henningkayser @nbbrooks