Skip to content

biz/dj-2890-fix-enabledebugging-state-update-issue #15551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

biz/dj-2890-fix-enabledebugging-state-update-issue #15551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e2dcb18
Update lock file
bzwrk Feb 10, 2025
f3133c3
Add an empty change
bzwrk Feb 10, 2025
45c9369
Bump component version
bzwrk Feb 10, 2025
064be28
Comment out the change
bzwrk Feb 10, 2025
3ee1a48
Add a comment
bzwrk Feb 10, 2025
3535aca
Bump version
bzwrk Feb 10, 2025
f1fd016
Fix enableDebugging state update issue
bzwrk Feb 11, 2025
45c5244
Fix type issue
bzwrk Feb 11, 2025
9f9ecbb
Merge branch 'master' into biz/dj-2872-keep-appmjs-files-up-to-date-i…
bzwrk Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/connect-react/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
<!-- markdownlint-disable MD024 -->
# Changelog

# [1.0.0-preview.29] - 2025-02-10

- Fix enableDebugging state update bug

# [1.0.0-preview.28] - 2025-02-05

- Surface SDK errors in the form
Expand Down
8 changes: 4 additions & 4 deletions packages/connect-react/examples/nextjs/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/connect-react/examples/nextjs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
},
"dependencies": {
"@pipedream/connect-react": "file:../..",
"@pipedream/sdk": "^1.3.2",
"@pipedream/sdk": "^1.3.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

LGTM! Minor version bump for @pipedream/sdk.

The update from ^1.3.2 to ^1.3.3 follows semantic versioning and should be backward compatible.

Let's verify the latest version and any breaking changes:

🌐 Web query:

What is the latest version of @pipedream/sdk and are there any breaking changes in version 1.3.3?

💡 Result:

The latest version of @pipedream/sdk listed in search results is v1.2.1, published on January 27, 2025[4]. While your query references version v1.3.3, no information about this specific version appears in any provided search results[4][7][8].

For existing versions mentioned:

  • v0.x versions (before v1) showed breaking changes like renaming components and removing helper functions[2]
  • v2 of Pipedream introduced major code scaffolding changes (e.g., wrapping steps with defineComponent instead of async functions)[1], but this refers to platform changes rather than SDK updates

The available documentation for @pipedream/sdk focuses on:

defineComponent({
    async run({ steps, $ }) { 
        // Code execution entry point
    }
})

with $ replacing legacy functions like $end/$respond via $.flow.exit/$.respond respectively[1][7]. No breaking changes are explicitly mentioned for SDK versions after v1.x[4][7].

Citations:

Action Required: Verify the intended version for @pipedream/sdk dependency

  • Our web query shows that the latest published version on npm is v1.2.1, not v1.3.3.
  • No breaking changes are documented for versions in the 1.x series.
  • It appears the package.json bump to ^1.3.3 may reference a version that isn’t available on npm, so please double-check if v1.3.3 is intended (e.g., an internal pre-release) or if the dependency version should align with the published release.

"next": "15.0.3",
"react": "19.0.0-rc-66855b96-20241106",
"react-dom": "19.0.0-rc-66855b96-20241106"
Expand Down
2 changes: 1 addition & 1 deletion packages/connect-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@pipedream/connect-react",
"version": "1.0.0-preview.28",
"version": "1.0.0-preview.29",
"description": "Pipedream Connect library for React",
"files": [
"dist"
Expand Down
9 changes: 2 additions & 7 deletions packages/connect-react/src/hooks/form-context.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export type FormContext<T extends ConfigurableProps> = {
setSubmitting: (submitting: boolean) => void;
submitting: boolean;
userId: string;
enableDebugging: boolean;
enableDebugging?: boolean;
};

export const skippablePropTypes = [
Expand Down Expand Up @@ -78,7 +78,7 @@ export const FormContextProvider = <T extends ConfigurableProps>({
const id = useId();

const {
component, configuredProps: __configuredProps, propNames, userId, sdkResponse, enableDebugging: __enableDebugging,
component, configuredProps: __configuredProps, propNames, userId, sdkResponse, enableDebugging,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Ensure consistent initialization of enableDebugging.

The enableDebugging value is passed directly from formProps to the context without any default value. This could lead to inconsistent behavior across the application.

Consider initializing with a default value:

-    component, configuredProps: __configuredProps, propNames, userId, sdkResponse, enableDebugging,
+    component, configuredProps: __configuredProps, propNames, userId, sdkResponse, enableDebugging = false,

Also applies to: 561-561

} = formProps;
const componentId = component.key;

Expand All @@ -104,11 +104,6 @@ export const FormContextProvider = <T extends ConfigurableProps>({
setSdkErrors,
] = useState<SdkError[]>([])

const [
enableDebugging
,
] = useState<boolean>(__enableDebugging === true)

const [
enabledOptionalProps,
setEnabledOptionalProps,
Expand Down
10 changes: 5 additions & 5 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading