-
Notifications
You must be signed in to change notification settings - Fork 5.5k
File Stash docs #17034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File Stash docs #17034
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Warning Rate limit exceeded@dannyroosevelt has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 51 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
WalkthroughThe changes introduce new documentation for Pipedream's File Stash feature, update the Connect API documentation to include the new Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant ConnectAPI
participant FileStash
Client->>ConnectAPI: Invoke Action (with optional stash_id)
alt stash_id provided
ConnectAPI->>FileStash: Sync files from /tmp using stash_id
FileStash-->>ConnectAPI: Return presigned URLs and stash metadata
end
ConnectAPI-->>Client: Respond with action output, stashId, and file URLs
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
🔭 Outside diff range comments (1)
docs-v2/pages/connect/components/index.mdx (1)
325-325:⚠️ Potential issueBroken link: update or remove invalid anchor
The link/connect/components/workflows#configure-accounts-to-use-your-end-users-authis 404ing in the MDX validation step. Please correct the path or update the anchor text to a valid section in your docs.🧰 Tools
🪛 GitHub Actions: Validate MDX Links
[error] 325-325: Broken link: /connect/components/workflows#configure-accounts-to-use-your-end-users-auth (file not found)
🧹 Nitpick comments (3)
docs-v2/pages/connect/api.mdx (1)
1851-1864: Nitpick: streamlinestash_idparameter description
The phrase “accessible outside of the execution environment” is wordy. Consider “accessible outside the execution environment” for conciseness.🧰 Tools
🪛 LanguageTool
[style] ~1855-~1855: This phrase is redundant. Consider using “outside”.
Context: ...File Store. This makes files accessible outside of the execution environment via presigned...(OUTSIDE_OF)
docs-v2/pages/connect/components/files.mdx (2)
1-3: Nitpick: unify import quote style
Consider using the same quote delimiter for imports (either all single or all double) to maintain consistency in MDX.
4-7: Nitpick: remove redundant phrasing
Change “making them accessible outside of Pipedream” to “making them accessible outside Pipedream” for brevity.🧰 Tools
🪛 LanguageTool
[style] ~6-~6: This phrase is redundant. Consider using “outside”.
Context: ...ream File Store, making them accessible outside of Pipedream. ## File Stash When you exe...(OUTSIDE_OF)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
components/notion/actions/create-page/create-page.mjs(1 hunks)docs-v2/pages/connect/_meta.tsx(1 hunks)docs-v2/pages/connect/api.mdx(5 hunks)docs-v2/pages/connect/components/_meta.tsx(1 hunks)docs-v2/pages/connect/components/files.mdx(1 hunks)docs-v2/pages/connect/components/index.mdx(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Validate MDX Links
docs-v2/pages/connect/components/index.mdx
[error] 325-325: Broken link: /connect/components/workflows#configure-accounts-to-use-your-end-users-auth (file not found)
🪛 GitHub Check: Lint Code Base
components/notion/actions/create-page/create-page.mjs
[warning] 10-10:
{{ts}} macro should be removed before committing
🪛 GitHub Actions: Pull Request Checks
components/notion/actions/create-page/create-page.mjs
[error] 1-1: Component folder name, component file name without extension, and component key without slug should be the same. See https://pipedream.com/docs/components/guidelines/#folder-structure
🪛 LanguageTool
docs-v2/pages/connect/components/files.mdx
[style] ~6-~6: This phrase is redundant. Consider using “outside”.
Context: ...ream File Store, making them accessible outside of Pipedream. ## File Stash When you exe...
(OUTSIDE_OF)
[uncategorized] ~129-~129: Loose punctuation mark.
Context: ..._uploadsarray includes: -localPath: The path to the file in the /tmp` dire...
(UNLIKELY_OPENING_PUNCTUATION)
docs-v2/pages/connect/api.mdx
[style] ~1855-~1855: This phrase is redundant. Consider using “outside”.
Context: ...File Store. This makes files accessible outside of the execution environment via presigned...
(OUTSIDE_OF)
🪛 Gitleaks (8.26.0)
docs-v2/pages/connect/components/files.mdx
111-111: Identified a pattern that may indicate AWS credentials, risking unauthorized cloud resource access and data breaches on AWS platforms.
(aws-access-token)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Verify TypeScript components
- GitHub Check: Publish TypeScript components
🔇 Additional comments (15)
docs-v2/pages/connect/_meta.tsx (1)
5-5: Label update aligns with new documentation structure
Changing"components"to"Tool Use"improves clarity and matches the new “Working with Files” subpage.docs-v2/pages/connect/components/index.mdx (1)
650-650: Approve: Added File Stash response detail
Including thestashproperty in the response example clearly documents the new File Stash feature.docs-v2/pages/connect/components/_meta.tsx (1)
1-4: Metadata for new “Working with Files” page looks correct
The keysindexandfilesmap properly toindex.mdxandfiles.mdx. Immutable export is appropriate.docs-v2/pages/connect/api.mdx (2)
1900-1901: Looks good: TypeScript SDK example includesstashId
ThestashIdfield is correctly added to theRunActionOptsin the TypeScript snippet.
1969-1976: Looks good: HTTP API cURL example uses snake_case
The JSON keys (auth_provision_id,project_id,ref_name,stash_id) align with REST conventions.docs-v2/pages/connect/components/files.mdx (10)
12-17: Approve: clear “How it works” section
Step-by-step syncing flow is concise and easy to follow.
20-25: Approve: usage guidance forstashId
The criteria for when to passstashIdare well-defined.
26-31: Approve: new stash ID options list
The bullet list correctly covers all ways to generate a new stash ID.
33-35: Approve: performance warning callout
Good use of a Callout to highlight response time trade-offs.
41-46: Approve: API Reference table
Parameter name, type, and description follow HTTP conventions (snake_case).
49-70: Approve: Node.js SDK example
Correctly demonstratesstashIdusage with the SDK’sactionRun.
73-95: Approve: HTTP (cURL) example
JSON request uses proper snake_case keys; illustrative and accurate.
127-132: Approve: explanation of$filestash_uploadsfields
Clear, accurate descriptions of each metadata property.🧰 Tools
🪛 LanguageTool
[uncategorized] ~129-~129: Loose punctuation mark.
Context: ..._uploadsarray includes: -localPath: The path to the file in the/tmp` dire...(UNLIKELY_OPENING_PUNCTUATION)
137-159: Approve: stash ID reuse examples
Demonstrates how to persist and reuse a stash across multiple runs in both SDK and cURL contexts.
191-194: Approve: file retention details
Clear statement of file and URL lifetimes in File Stash.
WHY
Summary by CodeRabbit
New Features
Documentation
stash_idparameter for file syncing and external access.