Skip to content

Conversation

@michelle0927
Copy link
Collaborator

@michelle0927 michelle0927 commented Jun 17, 2025

Resolves #17161

Fixes issue of the Slack source "New Reaction Added" getting an error when receiving events:
TypeError: this.slack.sdk(...).getConversationReplies is not a function

Slack thread

Summary by CodeRabbit

  • Bug Fixes

    • Improved reliability when retrieving Slack conversation replies in message processing.
  • Chores

    • Updated version numbers for multiple Slack components to reflect recent changes. No impact on functionality.

@michelle0927 michelle0927 self-assigned this Jun 17, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jun 17, 2025

Walkthrough

The changes include version number increments across several Slack-related source components and the package manifest. Additionally, a method invocation in the Slack base source was updated to call getConversationReplies directly on this.slack instead of via this.slack.sdk(). No other logic or structural changes were made.

Changes

File(s) Change Summary
components/slack/package.json Incremented package version from 0.10.0 to 0.10.1.
components/slack/sources/common/base.mjs Updated method call in getMessage to use this.slack.getConversationReplies directly.
components/slack/sources/new-channel-created/new-channel-created.mjs Bumped version from 0.0.9 to 0.0.10.
components/slack/sources/new-direct-message/new-direct-message.mjs Bumped version from 1.0.22 to 1.0.23.
components/slack/sources/new-interaction-event-received/new-interaction-event-received.mjs Bumped version from 0.0.19 to 0.0.20.
components/slack/sources/new-keyword-mention/new-keyword-mention.mjs Bumped version from 0.0.7 to 0.0.8.
components/slack/sources/new-message-in-channels/new-message-in-channels.mjs Bumped version from 1.0.24 to 1.0.25.
components/slack/sources/new-reaction-added/new-reaction-added.mjs Bumped version from 1.1.25 to 1.1.26.
components/slack/sources/new-saved-message/new-saved-message.mjs Bumped version from 0.0.5 to 0.0.6.
components/slack/sources/new-user-added/new-user-added.mjs Bumped version from 0.0.3 to 0.0.4.
components/slack/sources/new-user-mention/new-user-mention.mjs Bumped version from 0.0.7 to 0.0.8.

Poem

A hop, a skip, a version bump,
Slack sources get a tidy jump!
One method call, now more direct,
The code is clean, as you'd expect.
With numbers rising, onward bound,
🐇 In changelog fields, delight is found!

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

components/slack/sources/new-interaction-event-received/new-interaction-event-received.mjs

Oops! Something went wrong! :(

ESLint: 8.57.1

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
at Object.getPackageJSONURL (node:internal/modules/package_json_reader:255:9)
at packageResolve (node:internal/modules/esm/resolve:767:81)
at moduleResolve (node:internal/modules/esm/resolve:853:18)
at defaultResolve (node:internal/modules/esm/resolve:983:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:801:12)
at #cachedDefaultResolve (node:internal/modules/esm/loader:725:25)
at ModuleLoader.resolve (node:internal/modules/esm/loader:708:38)
at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:309:38)
at #link (node:internal/modules/esm/module_job:201:49)

components/slack/sources/new-direct-message/new-direct-message.mjs

Oops! Something went wrong! :(

ESLint: 8.57.1

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
at Object.getPackageJSONURL (node:internal/modules/package_json_reader:255:9)
at packageResolve (node:internal/modules/esm/resolve:767:81)
at moduleResolve (node:internal/modules/esm/resolve:853:18)
at defaultResolve (node:internal/modules/esm/resolve:983:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:801:12)
at #cachedDefaultResolve (node:internal/modules/esm/loader:725:25)
at ModuleLoader.resolve (node:internal/modules/esm/loader:708:38)
at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:309:38)
at #link (node:internal/modules/esm/module_job:201:49)

components/slack/sources/new-channel-created/new-channel-created.mjs

Oops! Something went wrong! :(

ESLint: 8.57.1

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
at Object.getPackageJSONURL (node:internal/modules/package_json_reader:255:9)
at packageResolve (node:internal/modules/esm/resolve:767:81)
at moduleResolve (node:internal/modules/esm/resolve:853:18)
at defaultResolve (node:internal/modules/esm/resolve:983:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:801:12)
at #cachedDefaultResolve (node:internal/modules/esm/loader:725:25)
at ModuleLoader.resolve (node:internal/modules/esm/loader:708:38)
at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:309:38)
at #link (node:internal/modules/esm/module_job:201:49)

  • 7 others

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3741b91 and f2961fb.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (11)
  • components/slack/package.json (1 hunks)
  • components/slack/sources/common/base.mjs (1 hunks)
  • components/slack/sources/new-channel-created/new-channel-created.mjs (1 hunks)
  • components/slack/sources/new-direct-message/new-direct-message.mjs (1 hunks)
  • components/slack/sources/new-interaction-event-received/new-interaction-event-received.mjs (1 hunks)
  • components/slack/sources/new-keyword-mention/new-keyword-mention.mjs (1 hunks)
  • components/slack/sources/new-message-in-channels/new-message-in-channels.mjs (1 hunks)
  • components/slack/sources/new-reaction-added/new-reaction-added.mjs (1 hunks)
  • components/slack/sources/new-saved-message/new-saved-message.mjs (1 hunks)
  • components/slack/sources/new-user-added/new-user-added.mjs (1 hunks)
  • components/slack/sources/new-user-mention/new-user-mention.mjs (1 hunks)
🔇 Additional comments (11)
components/slack/package.json (1)

3-3: Version bump to 0.10.1
Aligns the package version with the updated Slack source components in this release.

components/slack/sources/new-direct-message/new-direct-message.mjs (1)

8-8: Component version updated to 1.0.23
Consistent increment matching other Slack sources in this PR.

components/slack/sources/new-user-mention/new-user-mention.mjs (1)

9-9: Component version updated to 0.0.8
Version bump aligns with the broader Slack release cycle.

components/slack/sources/new-user-added/new-user-added.mjs (1)

8-8: Component version updated to 0.0.4
Matches the version updates across related Slack sources.

components/slack/sources/new-keyword-mention/new-keyword-mention.mjs (1)

9-9: Component version updated to 0.0.8
Keeps the versioning consistent with other Slack component updates.

components/slack/sources/common/base.mjs (1)

147-151: Inspecting the makeRequest implementation to confirm its behavior on error responses:

#!/bin/bash
# Print the block where makeRequest is defined and how it handles response.ok
sed -n '430,580p' components/slack/slack.app.mjs
components/slack/sources/new-saved-message/new-saved-message.mjs (1)

8-8: Version bump looks good

Nothing else changed; no further action required.

components/slack/sources/new-channel-created/new-channel-created.mjs (1)

8-8: Version increment acknowledged

LGTM.

components/slack/sources/new-reaction-added/new-reaction-added.mjs (1)

8-8: Version increment acknowledged

No functional changes detected.

components/slack/sources/new-message-in-channels/new-message-in-channels.mjs (1)

9-9: Version increment acknowledged

Nothing to add.

components/slack/sources/new-interaction-event-received/new-interaction-event-received.mjs (1)

6-6: Approve version bump
Version updated to 0.0.20 to pull in the getConversationReplies fix from the shared base component. No other changes are needed here.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@vercel
Copy link

vercel bot commented Jun 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Ignored (Inspect) Jun 17, 2025 8:00pm
pipedream-docs ⬜️ Ignored (Inspect) Jun 17, 2025 8:00pm
pipedream-docs-redirect-do-not-edit ⬜️ Ignored (Inspect) Jun 17, 2025 8:00pm

@michelle0927 michelle0927 moved this from Ready for PR Review to Doing in Component (Source and Action) Backlog Jun 17, 2025
@michelle0927 michelle0927 moved this from Doing to Ready for PR Review in Component (Source and Action) Backlog Jun 17, 2025
@michelle0927 michelle0927 mentioned this pull request Jun 17, 2025
@GTFalcao GTFalcao moved this from Ready for PR Review to Ready for QA in Component (Source and Action) Backlog Jun 17, 2025
@michelle0927 michelle0927 merged commit 34c4a50 into master Jun 17, 2025
17 checks passed
@michelle0927 michelle0927 deleted the slack-new-reaction-added-bug-fix branch June 17, 2025 20:22
joy-chanboop pushed a commit to joy-chanboop/pipedream that referenced this pull request Jun 21, 2025
* bug fix

* bump package version

* revert package version

* pnpm-lock.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]

4 participants