Skip to content

Conversation

@michelle0927
Copy link
Collaborator

@michelle0927 michelle0927 commented Jul 1, 2025

Resolves #7195

Summary by CodeRabbit

  • New Features

    • Added actions to create and update card items on Miro boards.
    • Introduced sources to emit events when card items are created or updated.
    • Enhanced property options for card items, including title, description, due date, theme, and geometry.
    • Added ability to select users from board members.
  • Bug Fixes

    • Improved timestamp tracking for event sources to prevent duplicate emissions.
  • Chores

    • Updated version numbers for multiple actions and sources.
    • Upgraded dependencies for improved compatibility.

@vercel
Copy link

vercel bot commented Jul 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Jul 1, 2025 7:05pm
pipedream-docs ⬜️ Ignored (Inspect) Jul 1, 2025 7:05pm
pipedream-docs-redirect-do-not-edit ⬜️ Ignored (Inspect) Jul 1, 2025 7:05pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 1, 2025

Walkthrough

This update introduces new actions and source components for Miro card items, including creating and updating card items, and event sources for card creation and updates. It also adds supporting API methods and property definitions in the app module. Several existing actions and sources have version bumps, and some internal refactoring is performed for shared base logic.

Changes

File(s) Change Summary
actions/create-card-item/create-card-item.mjs, actions/update-card-item/update-card-item.mjs Added new actions for creating and updating card items on a Miro board.
sources/card-item-updated/card-item-updated.mjs, sources/new-card-item-created/new-card-item-created.mjs Added new event sources for card item updated and new card item created events.
sources/card-item-updated/test-event.mjs, sources/new-card-item-created/test-event.mjs Added sample event data for the new sources.
miro_custom_app.app.mjs Added new propDefinitions for card item fields and new methods for card item API operations.
sources/common/base.mjs Added shared props (teamId, boardId) and timestamp helper methods for sources.
actions/create-board/create-board.mjs, actions/create-shape/create-shape.mjs, actions/create-sticky-note/create-sticky-note.mjs, actions/delete-board/delete-board.mjs, actions/delete-item/delete-item.mjs, actions/get-board/get-board.mjs, actions/get-items/get-items.mjs, actions/get-specific-item/get-specific-item.mjs, actions/list-boards/list-boards.mjs, actions/update-board/update-board.mjs, actions/update-shape/update-shape.mjs, actions/update-sticky-note/update-sticky-note.mjs Bumped version numbers of existing actions.
sources/item-position-changed/item-position-changed.mjs Removed explicit props section and bumped version.
package.json Updated package version and platform dependency.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Action (Create/Update Card Item)
    participant Miro App
    participant Miro API

    User->>Action (Create/Update Card Item): Provide card details
    Action (Create/Update Card Item)->>Miro App: Call createCardItem/updateCardItem
    Miro App->>Miro API: POST/PATCH /boards/{boardId}/cards/{itemId}
    Miro API-->>Miro App: Card item response
    Miro App-->>Action (Create/Update Card Item): Return response
    Action (Create/Update Card Item)-->>User: Show result
Loading
sequenceDiagram
    participant Source (New/Updated Card Item)
    participant Miro App
    participant Miro API
    participant User

    Source (New/Updated Card Item)->>Miro App: Fetch card items (pagination)
    Miro App->>Miro API: GET /boards/{boardId}/items?type=card
    Miro API-->>Miro App: Return card items
    Miro App-->>Source (New/Updated Card Item): Card item data
    Source (New/Updated Card Item)->>User: Emit event for new/updated card
Loading

Assessment against linked issues

Objective Addressed Explanation
Support for creating, updating, and syncing Miro card items (cards API integration) (#7195)
Event sources for card item creation and updates on a specific board (#7195)
Ability to specify board and card for sync operations (#7195)

Suggested reviewers

  • lcaresia

Poem

A rabbit hops through Miro's land,
Cards and boards at its command.
With updates, sources, actions new,
It syncs your cards—yes, that's true!
From Notion dreams to Miro's board,
The bunny brings your work restored.
🐇✨ Cards in sync, let’s all applaud!

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

components/miro_custom_app/actions/create-board/create-board.mjs

Oops! Something went wrong! :(

ESLint: 8.57.1

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
at Object.getPackageJSONURL (node:internal/modules/package_json_reader:255:9)
at packageResolve (node:internal/modules/esm/resolve:767:81)
at moduleResolve (node:internal/modules/esm/resolve:853:18)
at defaultResolve (node:internal/modules/esm/resolve:983:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:801:12)
at #cachedDefaultResolve (node:internal/modules/esm/loader:725:25)
at ModuleLoader.resolve (node:internal/modules/esm/loader:708:38)
at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:309:38)
at #link (node:internal/modules/esm/module_job:202:49)

components/miro_custom_app/actions/create-card-item/create-card-item.mjs

Oops! Something went wrong! :(

ESLint: 8.57.1

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
at Object.getPackageJSONURL (node:internal/modules/package_json_reader:255:9)
at packageResolve (node:internal/modules/esm/resolve:767:81)
at moduleResolve (node:internal/modules/esm/resolve:853:18)
at defaultResolve (node:internal/modules/esm/resolve:983:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:801:12)
at #cachedDefaultResolve (node:internal/modules/esm/loader:725:25)
at ModuleLoader.resolve (node:internal/modules/esm/loader:708:38)
at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:309:38)
at #link (node:internal/modules/esm/module_job:202:49)

components/miro_custom_app/actions/delete-board/delete-board.mjs

Oops! Something went wrong! :(

ESLint: 8.57.1

Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs
at Object.getPackageJSONURL (node:internal/modules/package_json_reader:255:9)
at packageResolve (node:internal/modules/esm/resolve:767:81)
at moduleResolve (node:internal/modules/esm/resolve:853:18)
at defaultResolve (node:internal/modules/esm/resolve:983:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:801:12)
at #cachedDefaultResolve (node:internal/modules/esm/loader:725:25)
at ModuleLoader.resolve (node:internal/modules/esm/loader:708:38)
at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:309:38)
at #link (node:internal/modules/esm/module_job:202:49)

  • 18 others
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@michelle0927 michelle0927 changed the title New Component - miro_custom_app New Components - miro_custom_app Jul 1, 2025
@michelle0927 michelle0927 marked this pull request as ready for review July 1, 2025 19:07
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 7

🧹 Nitpick comments (3)
components/miro_custom_app/actions/delete-item/delete-item.mjs (1)

24-38: Consider surfacing the API response and add minimal error handling

deleteItem may return useful metadata (HTTP status, deleted item object, etc.). Returning only itemId limits downstream steps’ visibility.
Also, any 4xx/5xx from the API will currently bubble up without context. A lightweight guard improves DX.

-    await this.app.deleteItem({
-      step,
-      boardId,
-      itemId,
-    });
-
-    step.export("$summary", "Successfully deleted item");
-
-    return itemId;
+    const res = await this.app.deleteItem({
+      step,
+      boardId,
+      itemId,
+    });
+
+    step.export(
+      "$summary",
+      `Successfully deleted item ${itemId} (HTTP ${res?.status || 200})`,
+    );
+
+    // Return the full response for downstream use
+    return res?.data ?? { itemId };
components/miro_custom_app/actions/delete-board/delete-board.mjs (1)

11-16: Minor tidy-up: reuse the destructured boardId

You already destructure boardId from this, but then call the API with this.boardId. Using the local variable avoids an unnecessary property access and keeps the code a bit cleaner.

-    await this.app.deleteBoard({
-      step,
-      boardId: this.boardId,
-    });
+    await this.app.deleteBoard({
+      step,
+      boardId,
+    });
components/miro_custom_app/sources/card-item-updated/test-event.mjs (1)

1-30: Consider differentiating the update test event.

The test event structure is identical to the card creation test event. While this provides consistency, consider making the modifiedAt timestamp more recent than createdAt or using a different modifiedBy user to better represent a realistic update scenario.

-  "modifiedAt": "2025-07-01T17:36:23Z",
+  "modifiedAt": "2025-07-01T17:40:15Z",
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7a48a21 and eabc8bc.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (22)
  • components/miro_custom_app/actions/create-board/create-board.mjs (1 hunks)
  • components/miro_custom_app/actions/create-card-item/create-card-item.mjs (1 hunks)
  • components/miro_custom_app/actions/create-shape/create-shape.mjs (1 hunks)
  • components/miro_custom_app/actions/create-sticky-note/create-sticky-note.mjs (1 hunks)
  • components/miro_custom_app/actions/delete-board/delete-board.mjs (1 hunks)
  • components/miro_custom_app/actions/delete-item/delete-item.mjs (1 hunks)
  • components/miro_custom_app/actions/get-board/get-board.mjs (1 hunks)
  • components/miro_custom_app/actions/get-items/get-items.mjs (1 hunks)
  • components/miro_custom_app/actions/get-specific-item/get-specific-item.mjs (1 hunks)
  • components/miro_custom_app/actions/list-boards/list-boards.mjs (1 hunks)
  • components/miro_custom_app/actions/update-board/update-board.mjs (1 hunks)
  • components/miro_custom_app/actions/update-card-item/update-card-item.mjs (1 hunks)
  • components/miro_custom_app/actions/update-shape/update-shape.mjs (1 hunks)
  • components/miro_custom_app/actions/update-sticky-note/update-sticky-note.mjs (1 hunks)
  • components/miro_custom_app/miro_custom_app.app.mjs (5 hunks)
  • components/miro_custom_app/package.json (2 hunks)
  • components/miro_custom_app/sources/card-item-updated/card-item-updated.mjs (1 hunks)
  • components/miro_custom_app/sources/card-item-updated/test-event.mjs (1 hunks)
  • components/miro_custom_app/sources/common/base.mjs (1 hunks)
  • components/miro_custom_app/sources/item-position-changed/item-position-changed.mjs (1 hunks)
  • components/miro_custom_app/sources/new-card-item-created/new-card-item-created.mjs (1 hunks)
  • components/miro_custom_app/sources/new-card-item-created/test-event.mjs (1 hunks)
🧰 Additional context used
🧠 Learnings (17)
components/miro_custom_app/actions/update-board/update-board.mjs (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
components/miro_custom_app/actions/delete-item/delete-item.mjs (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
components/miro_custom_app/package.json (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.
components/miro_custom_app/actions/create-board/create-board.mjs (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
components/miro_custom_app/actions/get-specific-item/get-specific-item.mjs (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
components/miro_custom_app/actions/create-shape/create-shape.mjs (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
components/miro_custom_app/actions/create-sticky-note/create-sticky-note.mjs (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
components/miro_custom_app/actions/update-shape/update-shape.mjs (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
components/miro_custom_app/sources/item-position-changed/item-position-changed.mjs (2)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
components/miro_custom_app/actions/update-sticky-note/update-sticky-note.mjs (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
components/miro_custom_app/sources/new-card-item-created/test-event.mjs (3)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
components/miro_custom_app/sources/card-item-updated/test-event.mjs (1)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
components/miro_custom_app/sources/common/base.mjs (1)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
components/miro_custom_app/actions/create-card-item/create-card-item.mjs (3)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-10-08T15:33:38.240Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12731
File: components/hackerone/actions/get-members/get-members.mjs:3-28
Timestamp: 2024-07-04T18:11:59.822Z
Learning: When exporting a summary message in the `run` method of an action, ensure the message is correctly formatted. For example, in the `hackerone-get-members` action, the correct format is `Successfully retrieved ${response.data.length} members`.
components/miro_custom_app/sources/card-item-updated/card-item-updated.mjs (4)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
components/miro_custom_app/sources/new-card-item-created/new-card-item-created.mjs (4)
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
components/miro_custom_app/actions/update-card-item/update-card-item.mjs (1)
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Lint Code Base
  • GitHub Check: Publish TypeScript components
  • GitHub Check: Verify TypeScript components
🔇 Additional comments (21)
components/miro_custom_app/actions/delete-item/delete-item.mjs (1)

7-7: Version bump looks good – double-check ancillary metadata

The patch version increment to 0.0.2 is appropriate for a non-functional change.
Please ensure corresponding updates are reflected in the CHANGELOG and any marketplace listing so users can understand what changed.

components/miro_custom_app/actions/delete-board/delete-board.mjs (1)

6-6: Version bump looks good

Incrementing the version to 0.0.2 cleanly reflects the release cycle and aligns with the other action updates in this PR. No issues spotted here.

components/miro_custom_app/sources/common/base.mjs (2)

14-28: LGTM! Well-structured prop definitions.

The new teamId and boardId props follow proper Pipedream patterns with propDefinition usage, and the dependency relationship between them is logically sound.


31-36: LGTM! Standard timestamp tracking implementation.

The _getLastTs and _setLastTs methods provide a clean abstraction for timestamp management in polling sources, following established patterns for event deduplication.

components/miro_custom_app/actions/update-shape/update-shape.mjs (1)

8-8: LGTM! Coordinated version bump.

The version increment aligns with the broader package update from 0.1.0 to 0.2.0 and appears to be part of a synchronized release.

components/miro_custom_app/actions/get-items/get-items.mjs (1)

7-7: LGTM! Consistent version increment.

The version bump is consistent with other action components and aligns with the overall package update strategy.

components/miro_custom_app/package.json (2)

3-3: LGTM! Appropriate version bump.

The minor version increment reflects the addition of new functionality (card item actions and sources) while maintaining backward compatibility.


16-16: Verify compatibility of @pipedream/platform v3.1.0 in miro_custom_app

A targeted check in components/miro_custom_app did not reveal any direct @pipedream/platform imports. Please confirm that the component has been updated to use the new v3 APIs and test it end-to-end:

  • Ensure any HTTP requests use
    import { axios } from "@pipedream/platform";
    instead of custom or older imports
  • Update uses of platform constants or errors (e.g. DEFAULT_POLLING_SOURCE_TIMER_INTERVAL, ConfigurationError) if their signatures changed
  • Run component/unit tests for miro_custom_app to catch runtime breakages

Diff in package.json:

--- package.json
-  "@pipedream/platform": "^1.5.1"
+  "@pipedream/platform": "^3.1.0"
components/miro_custom_app/actions/get-board/get-board.mjs (1)

6-6: LGTM! Consistent version management.

The version increment maintains consistency across all action components and supports the coordinated release strategy.

components/miro_custom_app/actions/update-board/update-board.mjs (1)

7-7: Patch version increment looks good

The bump to 0.0.2 keeps this action in sync with its peers and follows the repository’s versioning convention. No further issues spotted.

components/miro_custom_app/actions/create-board/create-board.mjs (1)

5-5: Version bump acknowledged

0.0.2 is consistent with the coordinated update across related actions. ✅

components/miro_custom_app/actions/list-boards/list-boards.mjs (1)

7-7: Minor version alignment verified

0.0.3 correctly advances this action ahead of the others that were already on 0.0.2; no other changes required.

components/miro_custom_app/actions/create-shape/create-shape.mjs (1)

7-7: Patch release recorded

The version tag now reads 0.0.2, matching the rest of the component set. All good.

components/miro_custom_app/actions/create-sticky-note/create-sticky-note.mjs (1)

8-8: Version updated without functional change

0.0.2 applied; no other modifications detected.

components/miro_custom_app/actions/get-specific-item/get-specific-item.mjs (1)

7-7: LGTM: Version bump is appropriate.

The version increment from "0.0.1" to "0.0.2" aligns with the coordinated maintenance update across multiple Miro custom app actions.

components/miro_custom_app/actions/update-sticky-note/update-sticky-note.mjs (1)

8-8: LGTM: Consistent version increment.

The version update from "0.0.1" to "0.0.2" is consistent with the coordinated maintenance update across the Miro custom app actions.

components/miro_custom_app/sources/item-position-changed/item-position-changed.mjs (1)

8-8: LGTM: Version increment with successful refactoring.

The version update from "0.0.1" to "0.0.2" is appropriate. The component appears to have been successfully refactored to use the shared base module while maintaining correct position change detection functionality.

components/miro_custom_app/sources/new-card-item-created/test-event.mjs (1)

1-30: LGTM: Comprehensive test event structure.

The test event provides a realistic and complete representation of a Miro card item with all expected properties including styling, geometry, positioning, API links, and user metadata. This will serve well as a test fixture for the new card item creation source component.

components/miro_custom_app/sources/card-item-updated/card-item-updated.mjs (1)

6-6: LGTM - Correct naming convention for update events.

The source name "Card Item Updated" correctly follows the component guidelines by not using the "New" prefix since this emits events for updated items rather than new items.

components/miro_custom_app/miro_custom_app.app.mjs (2)

143-152: LGTM - Improved fallback handling in itemId options.

The enhanced itemId options method with optional chaining and multiple fallback options (data?.content || data?.title || data?.[type] || type) provides robust label generation for different item types.


243-251: LGTM - New API methods follow consistent patterns.

The new API methods createCardItem, listBoardMembers, and updateCardItem follow the established patterns in the codebase and correctly implement the Miro API endpoints.

Also applies to: 300-307, 335-343

Copy link
Collaborator

@luancazarine luancazarine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @michelle0927, LGTM! Ready for QA!

@michelle0927 michelle0927 merged commit e281395 into master Jul 4, 2025
11 checks passed
@michelle0927 michelle0927 deleted the issue-7195 branch July 4, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[APP] Miro

3 participants