-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Revise HubSpot prop type #17965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise HubSpot prop type #17965
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
WalkthroughThis update primarily increments version numbers across numerous HubSpot action and source components. Additionally, the Changes
Sequence Diagram(s)Not applicable due to the absence of control flow or feature logic changes. Estimated code review effort🎯 2 (Simple) | ⏱️ ~6 minutes Assessment against linked issues
Assessment against linked issues: Out-of-scope changesNo out-of-scope changes detected. Suggested reviewers
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (5)
components/hubspot/sources/new-or-updated-company/new-or-updated-company.mjs (1)
12-12
: Remember to update release artifacts when bumping the version
The version bump to0.0.11
looks fine, but ensure the corresponding CHANGELOG entry and any marketplace metadata are updated so end-users can see what changed.components/hubspot/sources/new-engagement/new-engagement.mjs (1)
18-20
: Fix typo in option description“engagment” → “engagement”.
- description: "Filter results by the type of engagment", + description: "Filter results by the type of engagement",components/hubspot/actions/update-lead/update-lead.mjs (1)
10-10
: Add/update changelog entryEven for a simple patch bump, our release notes need an explicit line noting the prop-type alignment and the affected version numbers.
components/hubspot/actions/create-task/create-task.mjs (1)
35-46
: Confirm numericassociationType
handling after upstream type change
associationType
now comes fromhubspot.app.mjs
as an integer.
Downstream, this value is forwarded unchanged into the API payload (associationTypeId
) and never coerced. That’s fine, but if any persisted configs still store string IDs (created before this PR), strict equality or schema validation elsewhere may fail.Consider one of:
- associationTypeId: associationType, + associationTypeId: Number(associationType),or adding a migration note to documentation so users re-save existing workflows.
components/hubspot/actions/create-engagement/create-engagement.mjs (1)
44-55
: Guard against legacy stringassociationType
valuesFor backward-compatibility, explicitly coerce to number before using:
- associationTypeId: associationType, + associationTypeId: Number(associationType),
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (53)
components/hubspot/actions/add-contact-to-list/add-contact-to-list.mjs
(1 hunks)components/hubspot/actions/batch-create-or-update-contact/batch-create-or-update-contact.mjs
(1 hunks)components/hubspot/actions/create-associations/create-associations.mjs
(1 hunks)components/hubspot/actions/create-communication/create-communication.mjs
(1 hunks)components/hubspot/actions/create-company/create-company.mjs
(1 hunks)components/hubspot/actions/create-custom-object/create-custom-object.mjs
(1 hunks)components/hubspot/actions/create-deal/create-deal.mjs
(1 hunks)components/hubspot/actions/create-engagement/create-engagement.mjs
(1 hunks)components/hubspot/actions/create-lead/create-lead.mjs
(1 hunks)components/hubspot/actions/create-meeting/create-meeting.mjs
(1 hunks)components/hubspot/actions/create-note/create-note.mjs
(1 hunks)components/hubspot/actions/create-or-update-contact/create-or-update-contact.mjs
(1 hunks)components/hubspot/actions/create-task/create-task.mjs
(1 hunks)components/hubspot/actions/create-ticket/create-ticket.mjs
(1 hunks)components/hubspot/actions/enroll-contact-into-workflow/enroll-contact-into-workflow.mjs
(1 hunks)components/hubspot/actions/get-associated-meetings/get-associated-meetings.mjs
(1 hunks)components/hubspot/actions/get-company/get-company.mjs
(1 hunks)components/hubspot/actions/get-contact/get-contact.mjs
(1 hunks)components/hubspot/actions/get-deal/get-deal.mjs
(1 hunks)components/hubspot/actions/get-file-public-url/get-file-public-url.mjs
(1 hunks)components/hubspot/actions/get-meeting/get-meeting.mjs
(1 hunks)components/hubspot/actions/search-crm/search-crm.mjs
(1 hunks)components/hubspot/actions/update-company/update-company.mjs
(1 hunks)components/hubspot/actions/update-contact/update-contact.mjs
(1 hunks)components/hubspot/actions/update-custom-object/update-custom-object.mjs
(1 hunks)components/hubspot/actions/update-deal/update-deal.mjs
(1 hunks)components/hubspot/actions/update-lead/update-lead.mjs
(1 hunks)components/hubspot/hubspot.app.mjs
(1 hunks)components/hubspot/package.json
(1 hunks)components/hubspot/sources/delete-blog-article/delete-blog-article.mjs
(1 hunks)components/hubspot/sources/new-company-property-change/new-company-property-change.mjs
(1 hunks)components/hubspot/sources/new-contact-property-change/new-contact-property-change.mjs
(1 hunks)components/hubspot/sources/new-custom-object-property-change/new-custom-object-property-change.mjs
(1 hunks)components/hubspot/sources/new-deal-in-stage/new-deal-in-stage.mjs
(1 hunks)components/hubspot/sources/new-deal-property-change/new-deal-property-change.mjs
(1 hunks)components/hubspot/sources/new-email-event/new-email-event.mjs
(1 hunks)components/hubspot/sources/new-email-subscriptions-timeline/new-email-subscriptions-timeline.mjs
(1 hunks)components/hubspot/sources/new-engagement/new-engagement.mjs
(1 hunks)components/hubspot/sources/new-event/new-event.mjs
(1 hunks)components/hubspot/sources/new-form-submission/new-form-submission.mjs
(1 hunks)components/hubspot/sources/new-note/new-note.mjs
(1 hunks)components/hubspot/sources/new-or-updated-blog-article/new-or-updated-blog-article.mjs
(1 hunks)components/hubspot/sources/new-or-updated-company/new-or-updated-company.mjs
(1 hunks)components/hubspot/sources/new-or-updated-contact/new-or-updated-contact.mjs
(1 hunks)components/hubspot/sources/new-or-updated-crm-object/new-or-updated-crm-object.mjs
(1 hunks)components/hubspot/sources/new-or-updated-custom-object/new-or-updated-custom-object.mjs
(1 hunks)components/hubspot/sources/new-or-updated-deal/new-or-updated-deal.mjs
(1 hunks)components/hubspot/sources/new-or-updated-line-item/new-or-updated-line-item.mjs
(1 hunks)components/hubspot/sources/new-or-updated-product/new-or-updated-product.mjs
(1 hunks)components/hubspot/sources/new-social-media-message/new-social-media-message.mjs
(1 hunks)components/hubspot/sources/new-task/new-task.mjs
(1 hunks)components/hubspot/sources/new-ticket-property-change/new-ticket-property-change.mjs
(1 hunks)components/hubspot/sources/new-ticket/new-ticket.mjs
(1 hunks)
🧰 Additional context used
🧠 Learnings (5)
📚 Learning: source names in monday.com components don't need to start with "new" if they emit events for updated...
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#15376
File: components/monday/sources/name-updated/name-updated.mjs:6-6
Timestamp: 2025-01-23T03:55:15.166Z
Learning: Source names in Monday.com components don't need to start with "New" if they emit events for updated items (e.g., "Name Updated", "Column Value Updated") rather than new items. This follows the component guidelines exception where the "New" prefix is only required when emits are limited to new items.
Applied to files:
components/hubspot/sources/new-or-updated-custom-object/new-or-updated-custom-object.mjs
components/hubspot/sources/new-ticket-property-change/new-ticket-property-change.mjs
components/hubspot/sources/new-or-updated-product/new-or-updated-product.mjs
components/hubspot/sources/new-ticket/new-ticket.mjs
components/hubspot/sources/new-event/new-event.mjs
components/hubspot/sources/new-or-updated-deal/new-or-updated-deal.mjs
components/hubspot/sources/new-or-updated-blog-article/new-or-updated-blog-article.mjs
components/hubspot/sources/new-or-updated-contact/new-or-updated-contact.mjs
components/hubspot/sources/new-company-property-change/new-company-property-change.mjs
components/hubspot/sources/new-email-event/new-email-event.mjs
components/hubspot/sources/new-note/new-note.mjs
components/hubspot/sources/new-contact-property-change/new-contact-property-change.mjs
components/hubspot/sources/new-or-updated-company/new-or-updated-company.mjs
components/hubspot/sources/new-deal-property-change/new-deal-property-change.mjs
components/hubspot/sources/new-custom-object-property-change/new-custom-object-property-change.mjs
components/hubspot/sources/new-or-updated-line-item/new-or-updated-line-item.mjs
components/hubspot/sources/new-deal-in-stage/new-deal-in-stage.mjs
components/hubspot/sources/new-email-subscriptions-timeline/new-email-subscriptions-timeline.mjs
components/hubspot/sources/new-or-updated-crm-object/new-or-updated-crm-object.mjs
components/hubspot/sources/new-engagement/new-engagement.mjs
components/hubspot/sources/new-form-submission/new-form-submission.mjs
📚 Learning: in `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "c...
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14467
File: components/gainsight_px/actions/create-account/create-account.mjs:4-6
Timestamp: 2024-10-30T15:24:39.294Z
Learning: In `components/gainsight_px/actions/create-account/create-account.mjs`, the action name should be "Create Account" instead of "Create Memory".
Applied to files:
components/hubspot/actions/search-crm/search-crm.mjs
components/hubspot/actions/create-associations/create-associations.mjs
components/hubspot/actions/create-company/create-company.mjs
components/hubspot/actions/create-custom-object/create-custom-object.mjs
components/hubspot/actions/create-note/create-note.mjs
components/hubspot/actions/create-or-update-contact/create-or-update-contact.mjs
components/hubspot/actions/batch-create-or-update-contact/batch-create-or-update-contact.mjs
components/hubspot/actions/create-lead/create-lead.mjs
components/hubspot/actions/create-engagement/create-engagement.mjs
components/hubspot/actions/update-deal/update-deal.mjs
components/hubspot/actions/create-ticket/create-ticket.mjs
components/hubspot/actions/create-deal/create-deal.mjs
components/hubspot/actions/create-communication/create-communication.mjs
components/hubspot/actions/create-task/create-task.mjs
components/hubspot/actions/update-lead/update-lead.mjs
components/hubspot/actions/create-meeting/create-meeting.mjs
📚 Learning: in `components/the_magic_drip/sources/common.mjs`, when processing items in `getandprocessdata`, `sa...
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
Applied to files:
components/hubspot/sources/delete-blog-article/delete-blog-article.mjs
components/hubspot/sources/new-or-updated-product/new-or-updated-product.mjs
components/hubspot/sources/new-or-updated-deal/new-or-updated-deal.mjs
components/hubspot/sources/new-or-updated-blog-article/new-or-updated-blog-article.mjs
components/hubspot/sources/new-email-event/new-email-event.mjs
components/hubspot/sources/new-or-updated-company/new-or-updated-company.mjs
components/hubspot/sources/new-or-updated-line-item/new-or-updated-line-item.mjs
components/hubspot/sources/new-deal-in-stage/new-deal-in-stage.mjs
components/hubspot/sources/new-email-subscriptions-timeline/new-email-subscriptions-timeline.mjs
📚 Learning: the `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, an...
Learnt from: GTFalcao
PR: PipedreamHQ/pipedream#12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-07-24T02:06:47.016Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Applied to files:
components/hubspot/actions/update-custom-object/update-custom-object.mjs
📚 Learning: when developing pipedream components, do not add built-in node.js modules like `fs` to `package.json...
Learnt from: jcortes
PR: PipedreamHQ/pipedream#14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.
Applied to files:
components/hubspot/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Lint Code Base
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
🔇 Additional comments (54)
components/hubspot/actions/get-file-public-url/get-file-public-url.mjs (1)
7-7
: Version bump LGTMIncrementing the version to
0.0.18
is consistent with the other HubSpot action updates in this PR and signals the type-fix rollout without altering runtime logic. No further action required.components/hubspot/sources/new-or-updated-product/new-or-updated-product.mjs (1)
12-12
: Patch version bump aligns with bug-fix scope
Incrementing from0.0.10
→0.0.11
correctly signals an internal, non-breaking fix. No further issues spotted.components/hubspot/actions/update-company/update-company.mjs (1)
10-10
: Version bump is straightforward and consistentNo functional impact—just aligns this action with the broader HubSpot package updates. ✅
components/hubspot/actions/get-deal/get-deal.mjs (1)
9-9
: Version bump LGTMPatch-level increment from
0.0.17
→0.0.18
accurately reflects a backward-compatible bug fix. No further action needed.components/hubspot/sources/new-or-updated-blog-article/new-or-updated-blog-article.mjs (1)
10-10
: Patch version increment aligns component with upstream prop-type fix
The bump to0.0.11
is appropriate to surface the prop-type change across HubSpot components. No additional changes required.components/hubspot/sources/new-social-media-message/new-social-media-message.mjs (1)
9-9
: Version bump looks goodThe minor version increment accurately reflects a non-breaking change. No further action required.
components/hubspot/sources/new-or-updated-line-item/new-or-updated-line-item.mjs (1)
12-12
: Version bump looks correctIncrementing the version to
0.0.11
keeps this source in sync with the other HubSpot components that were updated to reflect the prop-type fix. No additional changes needed.components/hubspot/actions/create-communication/create-communication.mjs (1)
11-11
: Version bump looks good – remember to update release notesThe increment from
0.0.10
to0.0.11
is straightforward and poses no functional risk. Just make sure the corresponding changelog / release documentation reflects this version so downstream consumers understand why the patch was published.components/hubspot/sources/new-engagement/new-engagement.mjs (1)
11-11
: Version bump looks goodThe semantic-version increment is correctly applied and isolated. No further action needed here.
components/hubspot/sources/new-email-subscriptions-timeline/new-email-subscriptions-timeline.mjs (1)
9-9
: Version bump aligns with HubSpot prop-type fix – looks goodIncrementing to
0.0.24
cleanly propagates the breaking-type change without touching runtime logic.components/hubspot/actions/update-lead/update-lead.mjs (1)
10-10
: Patch-level version bump is appropriateIncrementing from
0.0.9
→0.0.10
accurately reflects a non-breaking internal change (prop-type fix elsewhere).components/hubspot/sources/new-or-updated-crm-object/new-or-updated-crm-object.mjs (1)
10-10
: Version bump looks correctIncrementing the version to
"0.0.24"
is appropriate and keeps the component in sync with the wider HubSpot updates introduced in this PR. No further action needed.components/hubspot/sources/new-or-updated-custom-object/new-or-updated-custom-object.mjs (1)
10-10
: Patch-level version bump is appropriateNo functional changes accompany this diff, so moving from 0.0.12 → 0.0.13 is consistent with SemVer.
components/hubspot/sources/new-deal-property-change/new-deal-property-change.mjs (1)
10-10
: Version increment acknowledgedOnly the version string changes; implementation remains intact. Nothing further to address.
components/hubspot/package.json (1)
3-3
: Package patch release looks fineBumping the collection from 1.3.0 → 1.3.1 to ship the internal prop-type fix and component patch releases is reasonable and keeps SemVer expectations.
components/hubspot/sources/new-or-updated-deal/new-or-updated-deal.mjs (1)
12-12
: Patch bump acceptedNo logic altered; 0.0.10 → 0.0.11 correctly reflects a non-breaking change.
components/hubspot/sources/new-ticket-property-change/new-ticket-property-change.mjs (1)
10-10
: OK to release as patchVersion update mirrors other HubSpot sources; no additional feedback.
components/hubspot/sources/new-company-property-change/new-company-property-change.mjs (1)
10-10
: Version bump only – no concerns
The update cleanly increments the component version without functional impact.components/hubspot/sources/new-contact-property-change/new-contact-property-change.mjs (1)
10-10
: Version increment acknowledged
No behavioural changes introduced; good to merge.components/hubspot/actions/add-contact-to-list/add-contact-to-list.mjs (1)
7-7
: Component version updated
Looks good – aligns with the coordinated package bump.components/hubspot/actions/get-contact/get-contact.mjs (1)
9-9
: Version string updated
Nothing else changed; change is correct.components/hubspot/actions/update-deal/update-deal.mjs (1)
10-10
: Minor version bump confirmed
No functional modifications detected.components/hubspot/sources/new-event/new-event.mjs (1)
11-11
: Version bump acknowledgedThe patch-level increment to
0.0.28
is consistent with the coordinated package update.
No functional changes introduced in this segment. ✔️components/hubspot/actions/update-contact/update-contact.mjs (1)
10-10
: Version bump acknowledgedPatch version updated to
0.0.19
; aligns with other HubSpot action bumps.
No additional changes detected.components/hubspot/actions/get-meeting/get-meeting.mjs (1)
9-9
: Version bump acknowledgedIncrement to
0.0.3
recorded.
No logic or contract modifications in this diff.components/hubspot/actions/create-custom-object/create-custom-object.mjs (1)
9-9
: Version bump acknowledgedPatch raised to
1.0.4
; consistent with wider module versioning strategy.
No functional impact observed.components/hubspot/actions/get-company/get-company.mjs (1)
9-9
: Version bump acknowledgedPatch increment to
0.0.18
looks good; no code changes beyond metadata.components/hubspot/actions/search-crm/search-crm.mjs (1)
20-20
: Patch-level version bump looks goodThe increment from
1.0.4
→1.0.5
is appropriate for the non-functional prop-type correction that lands elsewhere in the package. No other changes detected.components/hubspot/sources/new-ticket/new-ticket.mjs (1)
12-12
: Version updated to 0.0.24 – OKPatch bump aligns this source with the rest of the HubSpot package release. No further action needed.
components/hubspot/actions/create-ticket/create-ticket.mjs (1)
9-9
: 0.0.13 patch bump acknowledgedNo behavioural changes in the action itself; version increment is consistent with the global release.
components/hubspot/actions/enroll-contact-into-workflow/enroll-contact-into-workflow.mjs (1)
7-7
: Patch version 0.0.18 confirmedPure metadata change; implementation remains unchanged and valid.
components/hubspot/sources/new-email-event/new-email-event.mjs (1)
11-11
: Patch bump to 0.0.27 approvedVersioning is now consistent across email-event source and related components.
components/hubspot/actions/update-custom-object/update-custom-object.mjs (1)
9-9
: Version bump acknowledgedNo functional changes detected beyond the version increment to
1.0.4
. Looks good and consistent with the coordinated release.components/hubspot/actions/batch-create-or-update-contact/batch-create-or-update-contact.mjs (1)
7-7
: Minor version increment validatedThe update to
0.0.15
aligns with the other HubSpot actions in this PR. No further issues.components/hubspot/actions/get-associated-meetings/get-associated-meetings.mjs (1)
9-9
: Version updated to 0.0.3Change is isolated to metadata; implementation remains untouched. All good.
components/hubspot/actions/create-note/create-note.mjs (1)
10-10
: Bumped to 0.0.2No logic changes accompany the new version string. ✅
components/hubspot/actions/create-lead/create-lead.mjs (1)
12-12
: Version string bumped to 0.0.10Consistent with the overall patch release; nothing else to flag.
components/hubspot/sources/delete-blog-article/delete-blog-article.mjs (1)
9-9
: Patch-level bump looks correct.No functional code was changed beyond the version string, so a patch increment is appropriate here.
components/hubspot/sources/new-deal-in-stage/new-deal-in-stage.mjs (1)
12-12
: Confirm versioning strategy vs. breaking-type change upstream.Upstream in
hubspot.app.mjs
theassociationType
prop changed its type fromstring
→integer
.
If any code path in this source (or itscommon
helpers) transmits user-providedassociationType
, that is a breaking change for existing workflows. In that case, a minor/major bump (not just patch) would be safer to give users the chance to review. Please double-check.components/hubspot/sources/new-note/new-note.mjs (1)
11-11
: LGTM – patch bump only.File only updates the version; no further action required.
components/hubspot/actions/create-or-update-contact/create-or-update-contact.mjs (1)
9-9
: Version bump acknowledged, but audit downstream of the prop-type change.Same concern as above: if this action (via its shared helpers) ever forwards
associationType
, the upstream type shift could surface here. Please verify tests or run a manual check that nothing relies on the oldstring
type.components/hubspot/sources/new-or-updated-contact/new-or-updated-contact.mjs (1)
12-12
: Patch bump only – no objections.Change limited to the version string.
components/hubspot/hubspot.app.mjs (1)
370-370
: LGTM! Critical type fix correctly implemented.The type change from
"string"
to"integer"
correctly aligns with HubSpot's API response structure, wheretypeId
values are returned as integers. This resolves the type mismatch that was causing errors when users input custom expressions as strings.components/hubspot/sources/new-custom-object-property-change/new-custom-object-property-change.mjs (1)
9-9
: LGTM! Version increment is appropriate.The version bump from "0.0.8" to "0.0.9" is consistent with the coordinated release that includes the associationType type fix. No functional changes are needed in this component.
components/hubspot/sources/new-task/new-task.mjs (1)
11-11
: LGTM! Version increment is appropriate.The version bump from "1.0.4" to "1.0.5" aligns with the coordinated release strategy. No functional changes are required in this component.
components/hubspot/actions/create-deal/create-deal.mjs (1)
9-9
: LGTM! Version increment is appropriate.The version bump from "0.0.21" to "0.0.22" is consistent with the coordinated release. This component doesn't use associationType functionality, so only the version increment is needed.
components/hubspot/actions/create-company/create-company.mjs (1)
9-9
: LGTM! Version increment is appropriate.The version bump from "0.0.21" to "0.0.22" completes the coordinated release pattern. This component doesn't require functional changes related to the associationType fix.
components/hubspot/actions/create-task/create-task.mjs (1)
10-10
: Patch-level version bump looks goodNothing but the version string changed – no functional impact.
components/hubspot/actions/create-associations/create-associations.mjs (2)
8-8
: Patch-level version bump approvedNo code changes besides
"1.0.4" → "1.0.4"
.
72-79
: Ensure numeric comparison forassociationType
To prevent legacy string IDs from failing a strict match against the numeric
typeId
, coercethis.associationType
to a number before comparing. For example, incomponents/hubspot/actions/create-associations/create-associations.mjs
(around lines 72–79):- const association = results.find(({ typeId }) => typeId === this.associationType); + const association = results.find(({ typeId }) => typeId === Number(this.associationType));• This handles cases where
this.associationType
may still be a string (e.g."19"
), ensuring it matches the numerictypeId
.
• Alternatively, you could normalizeassociationType
once when it’s first set (e.g. in the constructor) to avoid repeatedNumber()
calls.
• Please verify that no other parts of the code rely onassociationType
remaining a string.components/hubspot/actions/create-meeting/create-meeting.mjs (2)
13-13
: Version bump only – approvedNo functional impact detected.
37-48
: Ensure UI enforces integer input forassociationType
Same note as in
create-task
: because the base prop is nowinteger
, make sure the component schema in production UI has been regenerated so users can’t input strings.components/hubspot/actions/create-engagement/create-engagement.mjs (1)
12-12
: Patch version bump acknowledgedPure metadata change – OK.
components/hubspot/sources/new-form-submission/new-form-submission.mjs (1)
9-9
: Source version bumped – no issuesOnly the version string changed; logic untouched.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @michelle0927, LGTM! Ready for QA!
Resolves #17964
Summary by CodeRabbit
New Features
Chores