-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Hubspot - limit on first run #18290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hubspot - limit on first run #18290
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Caution Review failedThe pull request is closed. WalkthroughThe HubSpot component version is bumped. In the new-or-updated-contact source, the version increments and getParams now accepts an Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Scheduler as Trigger
participant Source as NewOrUpdatedContact Source
participant DB as State DB
participant HubSpot as HubSpot CRM API
Scheduler->>Source: run()
Source->>DB: get("after")
DB-->>Source: after | null
alt First run (after == null)
Note right of Source: isFirstRun = true<br/>limit = 100<br/>dateProperty = createdate | lastmodifieddate
Source->>HubSpot: GET /contacts with params<br/>sort by dateProperty ASC<br/>properties = default + extras
else Incremental run
Note right of Source: isFirstRun = false<br/>limit = DEFAULT_LIMIT<br/>filterGroups: dateProperty > after
Source->>HubSpot: GET /contacts with params<br/>filter on dateProperty > after
end
HubSpot-->>Source: contacts batch
Source-->>Scheduler: emit records
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (2)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
WHY
When there are too many contacts, the timer can fail with a timeout error in the first poll.
Summary by CodeRabbit
New Features
Chores