-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Microsoft Teams - New Channel Message bug fix #18785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
WalkthroughThis PR bumps versions for Microsoft Teams component actions, sources, and the package. The listChannelMessages API endpoint is updated from the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes The majority of changes are homogeneous version bumps across multiple files following a consistent pattern. The primary functional change—updating the API endpoint in listChannelMessages—is a straightforward modification with clear motivation from the linked bug fix (#18767), requiring verification that the endpoint change resolves the descending message ordering issue. Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
components/microsoft_teams/microsoft_teams.app.mjs (1)
274-281
: Consider adding explicit ordering for consistency.For consistency with
listChatMessages
(line 287-290) and clarity, consider adding explicit ordering tolistChannelMessages
:async listChannelMessages({ teamId, channelId, }) { return this.makeRequest({ - path: `/teams/${teamId}/channels/${channelId}/messages`, + path: `/teams/${teamId}/channels/${channelId}/messages?$orderby=createdDateTime desc`, }); },This ensures both methods use
createdDateTime
consistently instead of relying on the defaultlastModifiedDateTime
ordering.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (13)
components/microsoft_teams/actions/create-channel/create-channel.mjs
(1 hunks)components/microsoft_teams/actions/list-channels/list-channels.mjs
(1 hunks)components/microsoft_teams/actions/list-shifts/list-shifts.mjs
(1 hunks)components/microsoft_teams/actions/send-channel-message/send-channel-message.mjs
(1 hunks)components/microsoft_teams/actions/send-chat-message/send-chat-message.mjs
(1 hunks)components/microsoft_teams/microsoft_teams.app.mjs
(1 hunks)components/microsoft_teams/package.json
(1 hunks)components/microsoft_teams/sources/new-channel-message/new-channel-message.mjs
(1 hunks)components/microsoft_teams/sources/new-channel/new-channel.mjs
(1 hunks)components/microsoft_teams/sources/new-chat-message/new-chat-message.mjs
(1 hunks)components/microsoft_teams/sources/new-chat/new-chat.mjs
(1 hunks)components/microsoft_teams/sources/new-team-member/new-team-member.mjs
(1 hunks)components/microsoft_teams/sources/new-team/new-team.mjs
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
- GitHub Check: Lint Code Base
🔇 Additional comments (14)
components/microsoft_teams/actions/list-shifts/list-shifts.mjs (1)
8-8
: LGTM!Version bump is appropriate for this package-wide release.
components/microsoft_teams/actions/create-channel/create-channel.mjs (1)
8-8
: LGTM!Version bump is appropriate for this package-wide release.
components/microsoft_teams/sources/new-team/new-team.mjs (1)
8-8
: LGTM!Version bump is appropriate for this package-wide release.
components/microsoft_teams/sources/new-chat-message/new-chat-message.mjs (1)
8-8
: LGTM!Version bump is appropriate for this package-wide release.
components/microsoft_teams/actions/list-channels/list-channels.mjs (1)
8-8
: LGTM!Version bump is appropriate for this package-wide release.
components/microsoft_teams/package.json (1)
3-3
: LGTM!Version bump is appropriate for this bug fix release.
components/microsoft_teams/actions/send-chat-message/send-chat-message.mjs (1)
8-8
: LGTM!Version bump is appropriate for this package-wide release.
components/microsoft_teams/microsoft_teams.app.mjs (1)
274-281
: Sort order handling is correct
The source passestrue
togetNewPaginatedResources
, ensuring descending order bylastModifiedDateTime
is handled properly.components/microsoft_teams/sources/new-channel/new-channel.mjs (1)
8-8
: LGTM! Version bump aligns with package release.The version increment is consistent with the broader version updates across Microsoft Teams components in this PR.
components/microsoft_teams/sources/new-chat/new-chat.mjs (1)
8-8
: LGTM! Version bump is consistent.The version increment aligns with other Microsoft Teams source components updated in this PR.
components/microsoft_teams/sources/new-team-member/new-team-member.mjs (1)
8-8
: LGTM! Version bump is appropriate.The version update is consistent with the package-wide version increment.
components/microsoft_teams/actions/send-channel-message/send-channel-message.mjs (1)
8-8
: LGTM! Action version bump is appropriate.The version increment is consistent with other Microsoft Teams actions updated in this PR.
components/microsoft_teams/sources/new-channel-message/new-channel-message.mjs (2)
8-8
: LGTM! Version bump for bug fix release.The version increment is appropriate for the bug fix addressing issue #18767.
29-53
: Verify the bug fix resolves the issue described in #18767.While the version bump is appropriate, the core fix (switching from
/delta
to/messages
endpoint inlistChannelMessages
) is inmicrosoft_teams.app.mjs
which is not included in this review. The comment on line 43 indicates awareness that messages are now sorted by last modified date.Please verify that:
- The trigger now fires correctly for subsequent messages (not just the first one)
- Messages are properly deduplicated using the
lastModifiedDateTime
field returned by the new endpoint- The removal of delta token handling doesn't cause any performance issues with large channels
You can test this by following the reproduction steps from issue #18767:
- Create a New Channel Message trigger
- Send a message → verify trigger fires
- Send another message → verify trigger fires again (this was failing before)
- Send several more messages → verify all triggers fire correctly
Resolves #18767
Summary by CodeRabbit
Bug Fixes
Chores