Skip to content

Conversation

michelle0927
Copy link
Collaborator

@michelle0927 michelle0927 commented Oct 16, 2025

Resolves #18767

Summary by CodeRabbit

  • Bug Fixes

    • Fixed channel message retrieval to use the correct API endpoint.
  • Chores

    • Updated Microsoft Teams integration package and all related actions and sources to latest versions.

Copy link

vercel bot commented Oct 16, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
pipedream-docs Ignored Ignored Oct 16, 2025 5:29pm
pipedream-docs-redirect-do-not-edit Ignored Ignored Oct 16, 2025 5:29pm

Copy link
Contributor

coderabbitai bot commented Oct 16, 2025

Walkthrough

This PR bumps versions for Microsoft Teams component actions, sources, and the package. The listChannelMessages API endpoint is updated from the /delta route to the /messages route for improved message ordering behavior.

Changes

Cohort / File(s) Summary
Action version bumps
components/microsoft_teams/actions/create-channel/create-channel.mjs, components/microsoft_teams/actions/list-channels/list-channels.mjs, components/microsoft_teams/actions/send-channel-message/send-channel-message.mjs, components/microsoft_teams/actions/send-chat-message/send-chat-message.mjs
Version updated from 0.0.10 to 0.0.11
List shifts action version
components/microsoft_teams/actions/list-shifts/list-shifts.mjs
Version updated from 0.0.7 to 0.0.8
Source version bumps
components/microsoft_teams/sources/new-channel-message/new-channel-message.mjs, components/microsoft_teams/sources/new-channel/new-channel.mjs, components/microsoft_teams/sources/new-chat-message/new-chat-message.mjs, components/microsoft_teams/sources/new-chat/new-chat.mjs, components/microsoft_teams/sources/new-team-member/new-team-member.mjs, components/microsoft_teams/sources/new-team/new-team.mjs
Version updated from 0.0.12 to 0.0.13
API endpoint update
components/microsoft_teams/microsoft_teams.app.mjs
listChannelMessages request path changed from /teams/${teamId}/channels/${channelId}/messages/delta to /teams/${teamId}/channels/${channelId}/messages
Package version
components/microsoft_teams/package.json
Version updated from 0.1.7 to 0.1.8

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

The majority of changes are homogeneous version bumps across multiple files following a consistent pattern. The primary functional change—updating the API endpoint in listChannelMessages—is a straightforward modification with clear motivation from the linked bug fix (#18767), requiring verification that the endpoint change resolves the descending message ordering issue.

Poem

🐰 A hop through the Teams, a version ascends,
Delta's gone, regular messages blend,
Six sources gleam, actions renewed,
From old paths to new, the fix ensued.
🎉 Bumped and polished, the bugs are mended!

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Out of Scope Changes Check ⚠️ Warning The pull request includes version bumps across multiple Microsoft Teams actions and sources that are unrelated to fixing the New Channel Message trigger and therefore extend beyond the scope of the objectives defined in issue #18767. Consider isolating the bug fix for listChannelMessages into its own PR and moving the general version metadata updates into a separate release or maintenance pull request.
Description Check ⚠️ Warning The pull request description only includes a resolve reference and does not include the required "## WHY" section or any explanation of the motivation and context as mandated by the repository template. Please add the "## WHY" section with details on the root cause of the bug, the rationale for the chosen fix, and any relevant context to satisfy the repository’s description template.
✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly and succinctly describes the primary change by indicating the fix for the Microsoft Teams New Channel Message bug, matching the linked issue and actual code modifications.
Linked Issues Check ✅ Passed The implementation of listChannelMessages has been updated to use the /messages endpoint per the first proposed fix in issue #18767, thereby addressing the trigger failure for subsequent messages and fulfilling the coding objectives.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch issue-18767

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@michelle0927 michelle0927 marked this pull request as ready for review October 16, 2025 17:31
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
components/microsoft_teams/microsoft_teams.app.mjs (1)

274-281: Consider adding explicit ordering for consistency.

For consistency with listChatMessages (line 287-290) and clarity, consider adding explicit ordering to listChannelMessages:

 async listChannelMessages({
   teamId,
   channelId,
 }) {
   return this.makeRequest({
-    path: `/teams/${teamId}/channels/${channelId}/messages`,
+    path: `/teams/${teamId}/channels/${channelId}/messages?$orderby=createdDateTime desc`,
   });
 },

This ensures both methods use createdDateTime consistently instead of relying on the default lastModifiedDateTime ordering.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6d19333 and 82399e9.

📒 Files selected for processing (13)
  • components/microsoft_teams/actions/create-channel/create-channel.mjs (1 hunks)
  • components/microsoft_teams/actions/list-channels/list-channels.mjs (1 hunks)
  • components/microsoft_teams/actions/list-shifts/list-shifts.mjs (1 hunks)
  • components/microsoft_teams/actions/send-channel-message/send-channel-message.mjs (1 hunks)
  • components/microsoft_teams/actions/send-chat-message/send-chat-message.mjs (1 hunks)
  • components/microsoft_teams/microsoft_teams.app.mjs (1 hunks)
  • components/microsoft_teams/package.json (1 hunks)
  • components/microsoft_teams/sources/new-channel-message/new-channel-message.mjs (1 hunks)
  • components/microsoft_teams/sources/new-channel/new-channel.mjs (1 hunks)
  • components/microsoft_teams/sources/new-chat-message/new-chat-message.mjs (1 hunks)
  • components/microsoft_teams/sources/new-chat/new-chat.mjs (1 hunks)
  • components/microsoft_teams/sources/new-team-member/new-team-member.mjs (1 hunks)
  • components/microsoft_teams/sources/new-team/new-team.mjs (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Publish TypeScript components
  • GitHub Check: Verify TypeScript components
  • GitHub Check: Lint Code Base
🔇 Additional comments (14)
components/microsoft_teams/actions/list-shifts/list-shifts.mjs (1)

8-8: LGTM!

Version bump is appropriate for this package-wide release.

components/microsoft_teams/actions/create-channel/create-channel.mjs (1)

8-8: LGTM!

Version bump is appropriate for this package-wide release.

components/microsoft_teams/sources/new-team/new-team.mjs (1)

8-8: LGTM!

Version bump is appropriate for this package-wide release.

components/microsoft_teams/sources/new-chat-message/new-chat-message.mjs (1)

8-8: LGTM!

Version bump is appropriate for this package-wide release.

components/microsoft_teams/actions/list-channels/list-channels.mjs (1)

8-8: LGTM!

Version bump is appropriate for this package-wide release.

components/microsoft_teams/package.json (1)

3-3: LGTM!

Version bump is appropriate for this bug fix release.

components/microsoft_teams/actions/send-chat-message/send-chat-message.mjs (1)

8-8: LGTM!

Version bump is appropriate for this package-wide release.

components/microsoft_teams/microsoft_teams.app.mjs (1)

274-281: Sort order handling is correct
The source passes true to getNewPaginatedResources, ensuring descending order by lastModifiedDateTime is handled properly.

components/microsoft_teams/sources/new-channel/new-channel.mjs (1)

8-8: LGTM! Version bump aligns with package release.

The version increment is consistent with the broader version updates across Microsoft Teams components in this PR.

components/microsoft_teams/sources/new-chat/new-chat.mjs (1)

8-8: LGTM! Version bump is consistent.

The version increment aligns with other Microsoft Teams source components updated in this PR.

components/microsoft_teams/sources/new-team-member/new-team-member.mjs (1)

8-8: LGTM! Version bump is appropriate.

The version update is consistent with the package-wide version increment.

components/microsoft_teams/actions/send-channel-message/send-channel-message.mjs (1)

8-8: LGTM! Action version bump is appropriate.

The version increment is consistent with other Microsoft Teams actions updated in this PR.

components/microsoft_teams/sources/new-channel-message/new-channel-message.mjs (2)

8-8: LGTM! Version bump for bug fix release.

The version increment is appropriate for the bug fix addressing issue #18767.


29-53: Verify the bug fix resolves the issue described in #18767.

While the version bump is appropriate, the core fix (switching from /delta to /messages endpoint in listChannelMessages) is in microsoft_teams.app.mjs which is not included in this review. The comment on line 43 indicates awareness that messages are now sorted by last modified date.

Please verify that:

  1. The trigger now fires correctly for subsequent messages (not just the first one)
  2. Messages are properly deduplicated using the lastModifiedDateTime field returned by the new endpoint
  3. The removal of delta token handling doesn't cause any performance issues with large channels

You can test this by following the reproduction steps from issue #18767:

  1. Create a New Channel Message trigger
  2. Send a message → verify trigger fires
  3. Send another message → verify trigger fires again (this was failing before)
  4. Send several more messages → verify all triggers fire correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Microsoft Teams - New Channel Message Trigger doesn't work after first message

1 participant