Enhance Aidaform component with new sources for monitoring form creat… #19055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion and responses. Added `New Form Created` and `New Form Response` sources, enabling event emission for new forms and responses. Updated `aidaform.app.mjs` with new prop definitions and methods for form management. Bump version to 0.7.0 in package.json.
Closed
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Contributor
WalkthroughThe changes refactor the AidaForm app module with a new API helper suite including pagination, URL construction, and request utilities, then introduce two new polling sources to monitor form creation and new form responses respectively. Changes
Sequence Diagram(s)sequenceDiagram
participant Timer
participant Source as Response Source
participant App as aidaform.app
participant API as AidaForm API
participant DB as State (db)
Timer->>Source: trigger run()
Source->>DB: _getLastDate()
DB-->>Source: lastDate
Source->>App: listResponses(formId)
App->>App: paginate({fn, params})
loop For each paginated batch
App->>API: GET /forms/{formId}/responses?limit=100&marker=X
API-->>App: responses + marker
App-->>App: yield each response
end
App-->>Source: responses array
Source->>Source: filter(created_at > lastDate)
Source->>Source: sort descending, reverse for emit
Source->>Source: emit each response (oldest→newest)
Source->>DB: _setLastDate(newest.created_at)
DB-->>Source: state saved
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Areas requiring extra attention:
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (4)
components/aidaform/aidaform.app.mjs(1 hunks)components/aidaform/package.json(1 hunks)components/aidaform/sources/new-form-response/new-form-response.mjs(1 hunks)components/aidaform/sources/new-form/new-form.mjs(1 hunks)
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-06-04T17:52:05.780Z
Learnt from: GTFalcao
Repo: PipedreamHQ/pipedream PR: 16954
File: components/salesloft/salesloft.app.mjs:14-23
Timestamp: 2025-06-04T17:52:05.780Z
Learning: In the Salesloft API integration (components/salesloft/salesloft.app.mjs), the _makeRequest method returns response.data which directly contains arrays for list endpoints like listPeople, listCadences, listUsers, and listAccounts. The propDefinitions correctly call .map() directly on these responses without needing to destructure a nested data property.
Applied to files:
components/aidaform/aidaform.app.mjs
📚 Learning: 2025-09-15T22:01:11.472Z
Learnt from: GTFalcao
Repo: PipedreamHQ/pipedream PR: 18362
File: components/leonardo_ai/actions/generate-image/generate-image.mjs:103-105
Timestamp: 2025-09-15T22:01:11.472Z
Learning: In Pipedream components, pipedream/platform's axios implementation automatically excludes undefined values from HTTP requests, so there's no need to manually check for truthiness before including properties in request payloads.
Applied to files:
components/aidaform/aidaform.app.mjs
📚 Learning: 2024-10-10T19:18:27.998Z
Learnt from: GTFalcao
Repo: PipedreamHQ/pipedream PR: 14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
Applied to files:
components/aidaform/sources/new-form/new-form.mjscomponents/aidaform/sources/new-form-response/new-form-response.mjs
🧬 Code graph analysis (2)
components/aidaform/sources/new-form/new-form.mjs (1)
components/aidaform/sources/new-form-response/new-form-response.mjs (2)
lastDate(35-35)responseArray(44-44)
components/aidaform/sources/new-form-response/new-form-response.mjs (1)
components/aidaform/sources/new-form/new-form.mjs (2)
lastDate(29-29)responseArray(30-30)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: pnpm publish
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
- GitHub Check: Lint Code Base
Collaborator
For Integration QA: |
Collaborator
|
Hi everyone, all test cases are passed! Ready for release! Test reports
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #13338
Summary by CodeRabbit
New Features
Chores