-
Notifications
You must be signed in to change notification settings - Fork 5.5k
Google Docs - Create File From Template - support templates in shared drives #19109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
WalkthroughAdd optional Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
GTFalcao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Hello everyone, I have tested this PR and there're some test cases failed or needed improvement. Please check test reports below for more information:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
components/google_docs/actions/create-document-from-template/create-document-from-template.mjs(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
components/google_docs/actions/create-document-from-template/create-document-from-template.mjs (1)
components/google_docs/actions/find-document/find-document.mjs (1)
props(11-11)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Lint Code Base
- GitHub Check: pnpm publish
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
- GitHub Check: Ensure component commits modify component versions
🔇 Additional comments (3)
components/google_docs/actions/create-document-from-template/create-document-from-template.mjs (3)
16-16: LGTM: Version bump is appropriate.The patch version bump is correct for adding optional features without breaking changes.
22-28: LGTM: Drive prop is well-structured.The optional
driveprop correctly uses the "watchedDrive" propDefinition and maintains backwards compatibility.
41-52: No issues found. The parent action fully supports thefolderIdparameter.The parent action (
@pipedream/google_drive/actions/create-file-from-template) explicitly defines afolderIdprop and uses it throughout its run method:
- For destination on regular drives when creating Google Docs and PDFs
- As fallback for
addParentswhen moving files to shared drivesThe child component correctly inherits the parent's run method via spread (
...others) and redefines thefolderIdprop to use the Google Docs app context for proper UI rendering. The implementation is sound.
components/google_docs/actions/create-document-from-template/create-document-from-template.mjs
Show resolved
Hide resolved
|
Hi everyone, all test cases are passed! Ready for release! Test reports
|
Followup to Issue #18958, PR #19053
Adds changes to support templates in shared drives for Google Docs - Create File From Template
Summary by CodeRabbit
New Features
Chores