Skip to content

Conversation

@michelle0927
Copy link
Collaborator

@michelle0927 michelle0927 commented Nov 17, 2025

Followup to Issue #18958, PR #19053

Adds changes to support templates in shared drives for Google Docs - Create File From Template

Summary by CodeRabbit

  • New Features

    • Added optional Drive selection parameter for document creation workflows.
    • Added optional Folder selection parameter to specify where newly created documents are stored.
  • Chores

    • Updated component and package versions and related dependency constraints.

@vercel
Copy link

vercel bot commented Nov 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
pipedream-docs Ignored Ignored Nov 18, 2025 5:22pm
pipedream-docs-redirect-do-not-edit Ignored Ignored Nov 18, 2025 5:22pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 17, 2025

Walkthrough

Add optional drive and folderId props to the Google Docs create-document-from-template action, pass drive into templateId propDefinition, and bump component and package versions; update the @pipedream/google_drive dependency.

Changes

Cohort / File(s) Summary
Create Document from Template
components/google_docs/actions/create-document-from-template/create-document-from-template.mjs
Bump exported version 0.0.6 → 0.0.7. Add optional public drive prop (propDefinition: [app, "watchedDrive"]). Extend templateId propDefinition to include (c) => ({ driveId: app.methods.getDriveId(c.drive) }). Add optional folderId prop (propDefinition: [app, "folderId", (c) => ({ drive: c.drive })]) with description.
Package manifest
components/google_docs/package.json
Bump package version 0.6.1 → 0.6.2. Update @pipedream/google_drive dependency constraint ^1.1.1 → ^1.3.1.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Check correctness of propDefinition callbacks and that app.methods.getDriveId exists and handles undefined drive.
  • Verify folderId description and optional flag align with UI/prop schema expectations.
  • Confirm dependency update doesn't require other adaptor changes.

Possibly related PRs

Suggested reviewers

  • luancazarine

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description provides context through issue and PR references but lacks details about the implementation and motivation as specified in the template. Complete the WHY section in the description template to explain the motivation and provide more implementation details for reviewers.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding support for templates in shared drives to the Google Docs Create File From Template action.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch issue-18958-2

Comment @coderabbitai help to get the list of available commands and usage tips.

GTFalcao
GTFalcao previously approved these changes Nov 17, 2025
Copy link
Collaborator

@GTFalcao GTFalcao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@GTFalcao GTFalcao moved this from Ready for PR Review to Ready for QA in Component (Source and Action) Backlog Nov 17, 2025
@vunguyenhung vunguyenhung moved this from Ready for QA to Changes Required in Component (Source and Action) Backlog Nov 18, 2025
@vunguyenhung
Copy link
Collaborator

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check test reports below for more information:

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 382459d and 623a127.

📒 Files selected for processing (1)
  • components/google_docs/actions/create-document-from-template/create-document-from-template.mjs (1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
components/google_docs/actions/create-document-from-template/create-document-from-template.mjs (1)
components/google_docs/actions/find-document/find-document.mjs (1)
  • props (11-11)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Lint Code Base
  • GitHub Check: pnpm publish
  • GitHub Check: Publish TypeScript components
  • GitHub Check: Verify TypeScript components
  • GitHub Check: Ensure component commits modify component versions
🔇 Additional comments (3)
components/google_docs/actions/create-document-from-template/create-document-from-template.mjs (3)

16-16: LGTM: Version bump is appropriate.

The patch version bump is correct for adding optional features without breaking changes.


22-28: LGTM: Drive prop is well-structured.

The optional drive prop correctly uses the "watchedDrive" propDefinition and maintains backwards compatibility.


41-52: No issues found. The parent action fully supports the folderId parameter.

The parent action (@pipedream/google_drive/actions/create-file-from-template) explicitly defines a folderId prop and uses it throughout its run method:

  • For destination on regular drives when creating Google Docs and PDFs
  • As fallback for addParents when moving files to shared drives

The child component correctly inherits the parent's run method via spread (...others) and redefines the folderId prop to use the Google Docs app context for proper UI rendering. The implementation is sound.

@michelle0927 michelle0927 moved this from Changes Required to Ready for QA in Component (Source and Action) Backlog Nov 18, 2025
@vunguyenhung vunguyenhung moved this from Ready for QA to Ready for Release in Component (Source and Action) Backlog Nov 19, 2025
@vunguyenhung
Copy link
Collaborator

Hi everyone, all test cases are passed! Ready for release!

Test reports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready for Release

Development

Successfully merging this pull request may close these issues.

4 participants