Slack - New Private Channel Created #19376
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
WalkthroughAdds a reusable base polling source and a new "New Private Channel Created" Slack v2 source that polls Slack's conversations.list API, filters private channels by creation timestamp, persists last-processed timestamp to DB, and emits events for new private channels. Changes
Sequence DiagramsequenceDiagram
participant Runtime as Polling Runtime
participant DB as Database
participant Source as Private Channel Source
participant SlackAPI as Slack API
participant Emitter as Event Emitter
Runtime->>Source: deploy() / run()
Source->>DB: _getLastTs()
DB-->>Source: lastTimestamp
loop paginate pages
Source->>SlackAPI: conversations.list(cursor)
SlackAPI-->>Source: channels + next_cursor
Source->>Source: filter channels where created > lastTimestamp
alt has next_cursor
Source->>Source: continue pagination
else no more pages
Source->>Source: end pagination
end
end
Source->>DB: _setLastTs(maxTimestamp)
DB-->>Source: ack
loop emit events
Source->>Source: generateMeta(channel)
Source->>Emitter: $emit(event, metadata)
Emitter-->>Emitter: downstream processing
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20–25 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (1)📚 Learning: 2024-12-12T19:23:09.039ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (3)
components/slack/package.json(2 hunks)components/slack/sources/common/base-polling.mjs(1 hunks)components/slack/sources/new-private-channel-created/new-private-channel-created.mjs(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2024-12-12T19:23:09.039Z
Learnt from: jcortes
Repo: PipedreamHQ/pipedream PR: 14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.
Applied to files:
components/slack/package.json
🧬 Code graph analysis (2)
components/slack/sources/new-private-channel-created/new-private-channel-created.mjs (1)
components/zep/actions/get-threads/get-threads.mjs (1)
max(39-39)
components/slack/sources/common/base-polling.mjs (2)
components/slack/sources/new-private-channel-created/new-private-channel-created.mjs (1)
lastTs(19-19)components/zep/actions/get-threads/get-threads.mjs (1)
max(39-39)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Publish TypeScript components
- GitHub Check: pnpm publish
- GitHub Check: Verify TypeScript components
- GitHub Check: Lint Code Base
🔇 Additional comments (3)
components/slack/sources/new-private-channel-created/new-private-channel-created.mjs (1)
47-53: LGTM!The
generateMetamethod correctly generates metadata with a unique ID, descriptive summary, and timestamp for event deduplication.components/slack/sources/common/base-polling.mjs (1)
1-50: Overall design looks good.The base polling class provides a clean abstraction with:
- Lifecycle hooks for deployment and regular execution
- Timestamp persistence via db
- Clear extension points for subclasses
- Appropriate use of Pipedream platform constants
The separation between deploy (limited to 10 events) and run (unlimited) is a good pattern for preventing overwhelming initial deployments.
components/slack/package.json (1)
17-17: Confirm the reason for downgrading @pipedream/platform from ^3.1.1 to ^3.1.0.The constraint was explicitly updated to
^3.1.1in a recent commit (138ef16) with the note "Update @pipedream/platform to latest version within major", but the current state shows it has been loosened back to^3.1.0. While the lock file ensures 3.1.1 is still installed, clarify whether this downgrade is intentional or should be reverted to^3.1.1.
components/slack_v2/sources/new-private-channel-created/new-private-channel-created.mjs
Show resolved
Hide resolved
components/slack_v2/sources/new-private-channel-created/new-private-channel-created.mjs
Show resolved
Hide resolved
components/slack_v2/sources/new-private-channel-created/new-private-channel-created.mjs
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 2
♻️ Duplicate comments (4)
components/slack_v2/sources/common/base-polling.mjs (2)
18-29: Clarify abstract method signatures to match call sites.
processEvents(max)callsthis.getResources(max)andthis.generateMeta(result), but the default implementations declare no parameters. Updating these signatures togetResources(max)andgenerateMeta(result)would better document the expected contract while still throwingConfigurationErrorby default.
30-40: Consider minimal error handling aroundprocessEventsfor robustness.If a subclass’s
getResourcesorgenerateMetathrows unexpectedly, the whole polling cycle fails. Wrapping the body ofprocessEventsin a small try/catch that logs and rethrows (so Pipedream can still handle the error) would make failures easier to diagnose without silently swallowing them.components/slack_v2/sources/new-private-channel-created/new-private-channel-created.mjs (2)
13-37: Guard Slack API response shape to avoid runtime errors.The destructuring
const { channels, response_metadata: { next_cursor: nextCursor }, } = await this.slack.conversationsList(params);will throw if
response_metadatais missing or null. It also assumeschannelsis always defined.Consider a more defensive pattern:
- const { - channels, response_metadata: { next_cursor: nextCursor }, - } = await this.slack.conversationsList(params); + const { + channels = [], + response_metadata: { next_cursor: nextCursor } = {}, + } = await this.slack.conversationsList(params);and then keep the
if (!channels.length) break;guard. This prevents hard failures if Slack omitsresponse_metadataorchannels.
29-37: Use inclusive timestamp comparison to avoid missing channels created at the boundary.Using
if (ts > lastTs)risks skipping channels whosecreatedtimestamp equalslastTsbut were created after the previous poll (Slack timestamps are second‑resolution). These would never be emitted.Switching to inclusive comparison and relying on unique dedupe by channel id avoids this:
- const ts = channel.created; - if (ts > lastTs) { + const ts = channel.created; + if (ts >= lastTs) { privateChannels.push(channel); maxTs = Math.max(ts, maxTs); }Given
dedupe: "unique"andgenerateMetausingchannel.id, re‑processing a boundary record is safe.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (4)
components/slack/package.json(1 hunks)components/slack_v2/package.json(1 hunks)components/slack_v2/sources/common/base-polling.mjs(1 hunks)components/slack_v2/sources/new-private-channel-created/new-private-channel-created.mjs(1 hunks)
🧰 Additional context used
🧠 Learnings (4)
📚 Learning: 2025-10-20T01:01:02.970Z
Learnt from: js07
Repo: PipedreamHQ/pipedream PR: 18744
File: components/slack_v2/actions/send-large-message/send-large-message.mjs:49-64
Timestamp: 2025-10-20T01:01:02.970Z
Learning: In components/slack_v2/actions/send-large-message/send-large-message.mjs, the metadata_event_payload prop is typed as string, so the code only needs to handle string-to-JSON parsing and does not need to handle object inputs.
Applied to files:
components/slack_v2/sources/new-private-channel-created/new-private-channel-created.mjscomponents/slack_v2/sources/common/base-polling.mjs
📚 Learning: 2024-10-10T19:18:27.998Z
Learnt from: GTFalcao
Repo: PipedreamHQ/pipedream PR: 14265
File: components/the_magic_drip/sources/common.mjs:35-43
Timestamp: 2024-10-10T19:18:27.998Z
Learning: In `components/the_magic_drip/sources/common.mjs`, when processing items in `getAndProcessData`, `savedIds` is intentionally updated with IDs of both emitted and non-emitted items to avoid emitting retroactive events upon first deployment and ensure only new events are emitted as they occur.
Applied to files:
components/slack_v2/sources/new-private-channel-created/new-private-channel-created.mjs
📚 Learning: 2024-10-08T15:33:38.240Z
Learnt from: GTFalcao
Repo: PipedreamHQ/pipedream PR: 12697
File: components/salesforce_rest_api/sources/common-webhook-methods.mjs:1-71
Timestamp: 2024-10-08T15:33:38.240Z
Learning: The `common-webhook-methods.mjs` object is designed to be extended, similar to an abstract class, and intentionally does not implement certain methods like `generateWebhookMeta` and `getEventType` to enforce implementation in subclasses.
Applied to files:
components/slack_v2/sources/common/base-polling.mjs
📚 Learning: 2024-12-12T19:23:09.039Z
Learnt from: jcortes
Repo: PipedreamHQ/pipedream PR: 14935
File: components/sailpoint/package.json:15-18
Timestamp: 2024-12-12T19:23:09.039Z
Learning: When developing Pipedream components, do not add built-in Node.js modules like `fs` to `package.json` dependencies, as they are native modules provided by the Node.js runtime.
Applied to files:
components/slack/package.json
🧬 Code graph analysis (2)
components/slack_v2/sources/new-private-channel-created/new-private-channel-created.mjs (1)
components/zep/actions/get-threads/get-threads.mjs (1)
max(39-39)
components/slack_v2/sources/common/base-polling.mjs (2)
components/slack_v2/sources/new-private-channel-created/new-private-channel-created.mjs (1)
lastTs(19-19)components/zep/actions/get-threads/get-threads.mjs (1)
max(39-39)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Publish TypeScript components
- GitHub Check: Verify TypeScript components
- GitHub Check: Lint Code Base
- GitHub Check: pnpm publish
🔇 Additional comments (3)
components/slack/package.json (1)
17-17: Confirm intended @pipedream/platform version (possible downgrade / mismatch).This package now depends on
@pipedream/platform"^3.1.0", while@pipedream/slack_v2depends on"^3.1.1". Please confirm this downgrade / mismatch is intentional and that Slack components don’t rely on features or fixes only available in^3.1.1. If not intentional, consider aligning both packages to the same version.components/slack_v2/package.json (1)
3-3: Version bump aligns with new source and shared base.The change to
"version": "0.2.0"matches the addition of the polling base and new source; no issues from a code perspective.components/slack_v2/sources/new-private-channel-created/new-private-channel-created.mjs (1)
47-52: Meta looks consistent with unique dedupe strategy.
generateMetaexposesid,summary, andtsbased on the channel object, which works well withdedupe: "unique"and provides a clear event summary. No changes needed here.
components/slack_v2/sources/new-private-channel-created/new-private-channel-created.mjs
Show resolved
Hide resolved
components/slack_v2/sources/new-private-channel-created/new-private-channel-created.mjs
Show resolved
Hide resolved
For Integration QA: |
|
Hi everyone, all test cases are passed! Ready for release! Test reports
|
|
/approve |
Resolves #19353
Summary by CodeRabbit
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.