Skip to content

Conversation

@RINNE-TAN
Copy link
Member

fix clippy

@RINNE-TAN RINNE-TAN requested review from Chronostasys and CjiW and removed request for Chronostasys March 28, 2023 05:11
@github-actions
Copy link

Benchmark for 95ac458

Click to view benchmark
Test Base PR %
multithreads(2) gc benchmark--65535 small objects(per thread) 1205.1±101.65µs 1191.0±256.45µs -1.17%
plimmixgc/multi-thread gc stress benchmark small objects 1130.3±30.49ms 1117.6±35.72ms -1.12%
plimmixgc/singlethread gc stress benchmark small objects 1036.4±14.81ms 1040.6±17.56ms +0.41%
singlethread gc benchmark--65535 small objects 1075.5±11.55µs 1007.8±6.41µs -6.29%
singlethread gc mark benchmark--65535 small objects 621.8±15.28µs 607.1±19.18µs -2.36%
singlethread gc sweep benchmark--65535 small objects 454.2±0.96µs 403.4±1.10µs -11.18%

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #256 (bb452d9) into master (943f7a1) will increase coverage by 0.10%.
The diff coverage is 80.08%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
+ Coverage   84.00%   84.11%   +0.10%     
==========================================
  Files          85       85              
  Lines       15309    15252      -57     
==========================================
- Hits        12861    12829      -32     
+ Misses       2448     2423      -25     
Impacted Files Coverage Δ
immix/src/collector.rs 90.89% <0.00%> (ø)
src/ast/builder/mod.rs 100.00% <ø> (ø)
src/ast/tokens.rs 45.83% <ø> (ø)
src/lsp/text.rs 80.76% <0.00%> (ø)
src/nomparser/helper.rs 90.51% <ø> (ø)
src/nomparser/mod.rs 87.50% <ø> (ø)
src/ast/plmod.rs 68.46% <20.00%> (+0.15%) ⬆️
src/ast/fmt.rs 38.96% <40.00%> (-0.11%) ⬇️
src/nomparser/array.rs 81.25% <50.00%> (ø)
src/nomparser/string_literal.rs 98.51% <50.00%> (ø)
... and 43 more

... and 1 file with indirect coverage changes

@github-actions
Copy link

Benchmark for 7d09952

Click to view benchmark
Test Base PR %
multithreads(2) gc benchmark--65535 small objects(per thread) 1127.9±116.42µs 1154.4±193.43µs +2.35%
plimmixgc/multi-thread gc stress benchmark small objects 924.0±40.38ms 921.3±26.25ms -0.29%
plimmixgc/singlethread gc stress benchmark small objects 836.4±16.15ms 847.0±13.44ms +1.27%
singlethread gc benchmark--65535 small objects 1034.1±1.82µs 1049.7±1.29µs +1.51%
singlethread gc mark benchmark--65535 small objects 564.8±2.13µs 568.2±1.29µs +0.60%
singlethread gc sweep benchmark--65535 small objects 470.3±0.75µs 483.5±8.39µs +2.81%

@github-actions
Copy link

Benchmark for 4bd5573

Click to view benchmark
Test Base PR %
multithreads(2) gc benchmark--65535 small objects(per thread) 1125.1±34.49µs 1235.5±411.39µs +9.81%
plimmixgc/multi-thread gc stress benchmark small objects 1114.2±40.48ms 1102.3±24.15ms -1.07%
plimmixgc/singlethread gc stress benchmark small objects 976.9±18.04ms 1012.0±24.57ms +3.59%
singlethread gc benchmark--65535 small objects 1049.4±3.63µs 1005.8±3.95µs -4.15%
singlethread gc mark benchmark--65535 small objects 595.6±1.10µs 605.1±6.35µs +1.60%
singlethread gc sweep benchmark--65535 small objects 453.2±0.86µs 403.7±2.98µs -10.92%

@github-actions
Copy link

Benchmark for e64859a

Click to view benchmark
Test Base PR %
multithreads(2) gc benchmark--65535 small objects(per thread) 1276.1±176.02µs 1354.1±237.29µs +6.11%
plimmixgc/multi-thread gc stress benchmark small objects 1317.7±37.19ms 1352.0±46.58ms +2.60%
plimmixgc/singlethread gc stress benchmark small objects 1216.5±31.22ms 1121.7±22.56ms -7.79%
singlethread gc benchmark--65535 small objects 1138.9±79.68µs 1109.7±53.77µs -2.56%
singlethread gc mark benchmark--65535 small objects 695.3±40.22µs 686.8±63.45µs -1.22%
singlethread gc sweep benchmark--65535 small objects 441.2±59.27µs 457.5±26.63µs +3.69%

@github-actions
Copy link

Benchmark for 697493f

Click to view benchmark
Test Base PR %
multithreads(2) gc benchmark--65535 small objects(per thread) 1140.8±35.17µs 1191.3±240.24µs +4.43%
plimmixgc/multi-thread gc stress benchmark small objects 923.8±47.78ms 926.0±28.80ms +0.24%
plimmixgc/singlethread gc stress benchmark small objects 860.7±17.26ms 871.6±16.73ms +1.27%
singlethread gc benchmark--65535 small objects 1043.4±7.99µs 1047.2±4.34µs +0.36%
singlethread gc mark benchmark--65535 small objects 571.7±6.44µs 566.8±5.50µs -0.86%
singlethread gc sweep benchmark--65535 small objects 470.7±1.01µs 483.0±7.55µs +2.61%

Copy link
Member

@Chronostasys Chronostasys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Chronostasys Chronostasys merged commit d2df613 into master Mar 28, 2023
@RINNE-TAN RINNE-TAN deleted the refactor/clippy branch April 13, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants