Skip to content

Conversation

@xieyuschen
Copy link
Member

No description provided.

@github-actions
Copy link

Benchmark for 0d2f78a

Click to view benchmark
Test Base PR %
allocation bench/malloc benchmark small objects 34.3±14.87ns 35.0±11.02ns +2.04%
allocation bench/singlethread gc alloc benchmark small objects 11.2±2.56ns 11.0±0.28ns -1.79%
multithreads(4) gc benchmark--65535 small objects(per thread) 1476.5±68.84µs 1482.3±205.07µs +0.39%
plimmixgc/multi-thread gc stress benchmark small objects 850.0±62.26ms 870.3±20.40ms +2.39%
plimmixgc/singlethread gc stress benchmark small objects 520.2±8.24ms 549.2±105.86ms +5.57%
singlethread gc benchmark--65535 small objects 742.7±7.95µs 741.3±6.28µs -0.19%

@xieyuschen xieyuschen force-pushed the griffin/improve/add-comments-4 branch from da52f8a to 6c4fa21 Compare January 23, 2024 07:22
@github-actions
Copy link

Benchmark for f8b640f

Click to view benchmark
Test Base PR %
allocation bench/malloc benchmark small objects 33.8±10.69ns 41.0±66.11ns +21.30%
allocation bench/singlethread gc alloc benchmark small objects 11.0±0.24ns 11.2±0.29ns +1.82%
multithreads(4) gc benchmark--65535 small objects(per thread) 1546.8±99.15µs 1621.8±168.91µs +4.85%
plimmixgc/multi-thread gc stress benchmark small objects 855.9±8.03ms 876.8±64.65ms +2.44%
plimmixgc/singlethread gc stress benchmark small objects 527.5±15.33ms 514.1±9.15ms -2.54%
singlethread gc benchmark--65535 small objects 745.0±8.48µs 766.4±12.51µs +2.87%

@xieyuschen xieyuschen force-pushed the griffin/improve/add-comments-4 branch from 6c4fa21 to aad393f Compare January 23, 2024 07:31
@github-actions
Copy link

Benchmark for af82e6f

Click to view benchmark
Test Base PR %
allocation bench/malloc benchmark small objects 36.5±24.94ns 36.4±21.73ns -0.27%
allocation bench/singlethread gc alloc benchmark small objects 11.0±0.22ns 11.4±0.21ns +3.64%
multithreads(4) gc benchmark--65535 small objects(per thread) 1478.1±100.23µs 1532.9±304.90µs +3.71%
plimmixgc/multi-thread gc stress benchmark small objects 859.2±5.70ms 858.9±4.98ms -0.03%
plimmixgc/singlethread gc stress benchmark small objects 516.2±8.96ms 551.7±112.11ms +6.88%
singlethread gc benchmark--65535 small objects 760.6±42.90µs 755.4±9.19µs -0.68%

@xieyuschen xieyuschen force-pushed the griffin/improve/add-comments-4 branch from 8f8b76b to fc715e9 Compare January 23, 2024 08:23
@github-actions
Copy link

Benchmark for 6282309

Click to view benchmark
Test Base PR %
allocation bench/malloc benchmark small objects 33.9±9.97ns 34.9±10.47ns +2.95%
allocation bench/singlethread gc alloc benchmark small objects 11.0±0.29ns 11.0±0.27ns 0.00%
multithreads(4) gc benchmark--65535 small objects(per thread) 1678.7±153.76µs 1866.2±457.81µs +11.17%
plimmixgc/multi-thread gc stress benchmark small objects 884.2±16.49ms 912.5±74.95ms +3.20%
plimmixgc/singlethread gc stress benchmark small objects 537.9±12.69ms 540.7±10.65ms +0.52%
singlethread gc benchmark--65535 small objects 751.0±11.04µs 754.1±14.88µs +0.41%

@xieyuschen xieyuschen force-pushed the griffin/improve/add-comments-4 branch from fc715e9 to f97fd2f Compare January 23, 2024 08:28
@github-actions
Copy link

Benchmark for d57332f

Click to view benchmark
Test Base PR %
allocation bench/malloc benchmark small objects 34.0±11.40ns 34.6±10.45ns +1.76%
allocation bench/singlethread gc alloc benchmark small objects 11.3±1.90ns 11.2±1.08ns -0.88%
multithreads(4) gc benchmark--65535 small objects(per thread) 1639.0±94.73µs 1630.3±401.18µs -0.53%
plimmixgc/multi-thread gc stress benchmark small objects 857.1±6.69ms 849.9±7.96ms -0.84%
plimmixgc/singlethread gc stress benchmark small objects 545.9±106.28ms 516.3±8.22ms -5.42%
singlethread gc benchmark--65535 small objects 758.7±12.21µs 752.7±14.77µs -0.79%

@codecov
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (ed16221) 86.52% compared to head (b60dbd5) 86.52%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #376   +/-   ##
=======================================
  Coverage   86.52%   86.52%           
=======================================
  Files         110      110           
  Lines       25904    25941   +37     
=======================================
+ Hits        22413    22446   +33     
- Misses       3491     3495    +4     
Files Coverage Δ
src/ast/builder/mod.rs 33.33% <ø> (ø)
src/ast/ctx/completion.rs 86.79% <100.00%> (+0.31%) ⬆️
src/ast/ctx/lsp.rs 97.77% <ø> (ø)
src/ast/macros.rs 92.59% <ø> (ø)
src/ast/node/cast.rs 96.12% <100.00%> (ø)
src/ast/node/error.rs 58.82% <100.00%> (ø)
src/ast/node/function.rs 89.34% <100.00%> (ø)
src/ast/node/function/generator.rs 98.72% <ø> (ø)
src/ast/node/interface.rs 84.15% <100.00%> (ø)
src/ast/node/node_result.rs 86.29% <100.00%> (ø)
... and 13 more

@github-actions
Copy link

Benchmark for 57d200f

Click to view benchmark
Test Base PR %
allocation bench/malloc benchmark small objects 34.0±11.52ns 33.5±9.08ns -1.47%
allocation bench/singlethread gc alloc benchmark small objects 20.7±2.55ns 11.1±0.51ns -46.38%
multithreads(4) gc benchmark--65535 small objects(per thread) 1564.2±103.26µs 1751.1±428.08µs +11.95%
plimmixgc/multi-thread gc stress benchmark small objects 851.5±4.41ms 860.5±27.36ms +1.06%
plimmixgc/singlethread gc stress benchmark small objects 520.2±19.43ms 517.3±7.82ms -0.56%
singlethread gc benchmark--65535 small objects 749.3±9.60µs 749.7±17.11µs +0.05%

@xieyuschen xieyuschen force-pushed the griffin/improve/add-comments-4 branch from ccf1bc2 to 17871de Compare January 23, 2024 10:18
@github-actions
Copy link

Benchmark for cfa7ee4

Click to view benchmark
Test Base PR %
allocation bench/malloc benchmark small objects 34.6±16.60ns 34.5±14.03ns -0.29%
allocation bench/singlethread gc alloc benchmark small objects 11.1±1.16ns 11.2±1.84ns +0.90%
multithreads(4) gc benchmark--65535 small objects(per thread) 1606.2±64.27µs 1695.9±444.23µs +5.58%
plimmixgc/multi-thread gc stress benchmark small objects 879.3±71.16ms 817.2±2.22ms -7.06%
plimmixgc/singlethread gc stress benchmark small objects 517.3±8.62ms 517.5±8.02ms +0.04%
singlethread gc benchmark--65535 small objects 774.2±34.17µs 746.8±10.79µs -3.54%

@github-actions
Copy link

Benchmark for 22b6cf1

Click to view benchmark
Test Base PR %
allocation bench/malloc benchmark small objects 35.0±15.09ns 34.5±11.07ns -1.43%
allocation bench/singlethread gc alloc benchmark small objects 11.1±1.50ns 11.1±0.88ns 0.00%
multithreads(4) gc benchmark--65535 small objects(per thread) 1536.3±97.75µs 1599.3±221.26µs +4.10%
plimmixgc/multi-thread gc stress benchmark small objects 854.9±6.18ms 831.4±5.17ms -2.75%
plimmixgc/singlethread gc stress benchmark small objects 518.5±7.99ms 519.0±8.53ms +0.10%
singlethread gc benchmark--65535 small objects 735.5±11.04µs 748.8±30.55µs +1.81%

@xieyuschen xieyuschen force-pushed the griffin/improve/add-comments-4 branch from 85e8c18 to b586321 Compare January 24, 2024 07:11
@github-actions
Copy link

Benchmark for 710fec5

Click to view benchmark
Test Base PR %
allocation bench/malloc benchmark small objects 33.7±10.69ns 34.9±13.25ns +3.56%
allocation bench/singlethread gc alloc benchmark small objects 11.0±0.98ns 11.1±0.97ns +0.91%
multithreads(4) gc benchmark--65535 small objects(per thread) 1403.8±40.56µs 1681.1±327.14µs +19.75%
plimmixgc/multi-thread gc stress benchmark small objects 868.0±51.58ms 865.7±34.67ms -0.26%
plimmixgc/singlethread gc stress benchmark small objects 517.8±8.57ms 515.0±9.56ms -0.54%
singlethread gc benchmark--65535 small objects 751.4±4.25µs 755.1±9.51µs +0.49%

@xieyuschen xieyuschen force-pushed the griffin/improve/add-comments-4 branch from b586321 to b60dbd5 Compare January 24, 2024 07:16
@github-actions
Copy link

Benchmark for 5e0cbea

Click to view benchmark
Test Base PR %
allocation bench/malloc benchmark small objects 32.7±8.32ns 34.7±10.63ns +6.12%
allocation bench/singlethread gc alloc benchmark small objects 11.2±1.54ns 11.2±1.52ns 0.00%
multithreads(4) gc benchmark--65535 small objects(per thread) 1626.3±50.83µs 1705.6±183.25µs +4.88%
plimmixgc/multi-thread gc stress benchmark small objects 850.2±8.05ms 817.1±5.91ms -3.89%
plimmixgc/singlethread gc stress benchmark small objects 514.9±7.50ms 518.7±7.99ms +0.74%
singlethread gc benchmark--65535 small objects 757.5±12.80µs 760.3±23.46µs +0.37%

Copy link
Member

@Chronostasys Chronostasys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xieyuschen xieyuschen merged commit ec71f7d into master Jan 24, 2024
@xieyuschen xieyuschen deleted the griffin/improve/add-comments-4 branch January 24, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants