-
-
Notifications
You must be signed in to change notification settings - Fork 1
improvement: add comments for emit functions and llvm builder #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for 0d2f78aClick to view benchmark
|
da52f8a to
6c4fa21
Compare
Benchmark for f8b640fClick to view benchmark
|
6c4fa21 to
aad393f
Compare
Benchmark for af82e6fClick to view benchmark
|
8f8b76b to
fc715e9
Compare
Benchmark for 6282309Click to view benchmark
|
fc715e9 to
f97fd2f
Compare
Benchmark for d57332fClick to view benchmark
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #376 +/- ##
=======================================
Coverage 86.52% 86.52%
=======================================
Files 110 110
Lines 25904 25941 +37
=======================================
+ Hits 22413 22446 +33
- Misses 3491 3495 +4
|
Benchmark for 57d200fClick to view benchmark
|
ccf1bc2 to
17871de
Compare
Benchmark for cfa7ee4Click to view benchmark
|
Chronostasys
requested changes
Jan 24, 2024
Benchmark for 22b6cf1Click to view benchmark
|
85e8c18 to
b586321
Compare
Benchmark for 710fec5Click to view benchmark
|
b586321 to
b60dbd5
Compare
Benchmark for 5e0cbeaClick to view benchmark
|
Chronostasys
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.