Skip to content

Handle Arabic characters #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2015
Merged

Handle Arabic characters #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/store.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@ ConceptNet.prototype.lookup = function(URI, params, callback) {
var limit = params.limit || 50;
var offset = params.offset || 0;

var path = "/data/" + this.version + String(URI) + "?limit=" + limit + "&offset=" + offset;
var path = "/data/" + this.version + String(encodeURIComponent(URI)) +
"?limit=" + limit + "&offset=" + offset;

if ( params.filter === "core" ) {
path += "&filter=core";
}
Expand Down
10 changes: 10 additions & 0 deletions test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,16 @@ describe('conceptNet', function tests() {
);
});

it('handles concepts in other languages', function otherLangTest(done) {
this.timeout(1000);
var cnet = new conceptNet();
cnet.lookup("c/ar/سلام/",{
filter: "core"}, function(err, result){
assert(result.edges.length === 7);
done();
}
);
});
});

it('is possible to use search method to retrieve results', function test(done) {
Expand Down