Skip to content

Conversation

@kengz
Copy link
Contributor

@kengz kengz commented Mar 20, 2016

Hi, I notice it's been a while since the last update, and there's considerable changes in ConceptNet 5.4. Can you review the PR and publish it so we can use the latest ConceptNet?

changes:

  • Update to be compatible with ConceptNet 5.4
  • Add URI standardization
  • Search in ConceptNet 5.4 is for finding edges. Update the tests and docs
  • update docs and tests

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8257873 on kengz:master into dfbe1b1 on Planeshifter:master.

Planeshifter added a commit that referenced this pull request Mar 21, 2016
update for ConceptNet 5.4; add URIstd for standardization feature
@Planeshifter Planeshifter merged commit 5587b70 into Planeshifter:master Mar 21, 2016
@kengz
Copy link
Contributor Author

kengz commented Mar 21, 2016

Forgot to mention, this resolves #4

@kengz
Copy link
Contributor Author

kengz commented Mar 21, 2016

@Planeshifter can you pls announce when the new package is published to npm? Would love to use it ASAP thx.

@Planeshifter
Copy link
Owner

Thanks for your additions and help! I am right now improving my code a bit and will publish a new version tonight (in not more than three hours).

@Planeshifter
Copy link
Owner

New version 0.3.0 of the package is online. I changed the name of the URIstd method to getURI to make it more descriptive.

@kengz
Copy link
Contributor Author

kengz commented Mar 21, 2016

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants