[SWP-5969] - Allow missing credentials to make use of injected IAM role credentials #65
Conversation
rickschubert
left a comment
rickschubert
left a comment
There was a problem hiding this comment.
This looks good! I will not request changes here but rather comment as PHP is not my field of expertise.
| /** | ||
| * Make sure some AWS credentials were provided to the configuration array. | ||
| * | ||
| * @return bool |
There was a problem hiding this comment.
In this JavaDoc string, can you type the input argument as well?
There was a problem hiding this comment.
It's PHPDoc, which I guess is pretty much the same. We could indeed add @param array $config - for consistency, but believe we just took the code that was added as part of the PR to bring this functionality into the 0.4 branch.
Could we also bring in over the EventBridgeBroadcasterTest and SnsBroadcasterTest?
oaklees
left a comment
oaklees
left a comment
There was a problem hiding this comment.
Good stuff. Only thing for me is also bringing the tests over that cover the introduced functionality, and then also a little into look into why we now need --no-scripts.
| /** | ||
| * Make sure some AWS credentials were provided to the configuration array. | ||
| * | ||
| * @return bool |
There was a problem hiding this comment.
It's PHPDoc, which I guess is pretty much the same. We could indeed add @param array $config - for consistency, but believe we just took the code that was added as part of the PR to bring this functionality into the 0.4 branch.
Could we also bring in over the EventBridgeBroadcasterTest and SnsBroadcasterTest?
This is to support the migration from IAM users to IAM roles for applications running earlier versions of Laravel (< 8).