Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No method for -layer #187

Closed
tpoisot opened this issue May 6, 2023 · 0 comments · Fixed by #188
Closed

No method for -layer #187

tpoisot opened this issue May 6, 2023 · 0 comments · Fixed by #188
Labels
component:SimpleSDMLayers effort:low new feature priority:high

Comments

@tpoisot
Copy link
Member

tpoisot commented May 6, 2023

There's no method to take the negative of a layer, need one instead of doing 0 - layer
tpoisot added a commit that referenced this issue May 13, 2023
@tpoisot
feat(layers): add -layer and !layer
97bbc9b 
Closes #187
@tpoisot tpoisot mentioned this issue May 13, 2023
Merged
tpoisot added a commit that referenced this issue May 13, 2023
@tpoisot
feat(layers): add an overload to to -/! on a layer
54807d5 
* feat(layers): allow creation from BitMatrix

* feat(layers): add -layer and !layer

Closes #187

* test(layers): add unit tests for the layer negation

* semver(layers): update the version number with new features

* bug(layers): use broadcast

The previous implementation would have crashed the F out on layers with
nothing-valued cells
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:SimpleSDMLayers effort:low new feature priority:high
Projects
Species Distribution Toolkit
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add methods to invert a layer PoisotLab/SpeciesDistributionToolkit.jl
1 participant
@tpoisot