Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods to invert a layer #188

Merged
merged 5 commits into from
May 13, 2023
Merged

Add methods to invert a layer #188

merged 5 commits into from
May 13, 2023

Conversation

tpoisot
Copy link
Member

@tpoisot tpoisot commented May 13, 2023

This closes #187 by adding -layer and !layer, which will help when working with masks

@github-actions
Copy link
Contributor

@tpoisot tpoisot marked this pull request as ready for review May 13, 2023 16:02
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 83.33% and project coverage change: +0.21 🎉

Comparison is base (31fcb88) 53.34% compared to head (7186318) 53.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
+ Coverage   53.34%   53.55%   +0.21%     
==========================================
  Files          59       59              
  Lines        1676     1688      +12     
==========================================
+ Hits          894      904      +10     
- Misses        782      784       +2     
Flag Coverage Δ
unittests 53.55% <83.33%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
SimpleSDMLayers/src/lib/types.jl 92.30% <50.00%> (-7.70%) ⬇️
SimpleSDMLayers/src/lib/overloads.jl 74.31% <100.00%> (+2.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

The previous implementation would have crashed the F out on layers with
nothing-valued cells
@tpoisot tpoisot merged commit 54807d5 into main May 13, 2023
@tpoisot tpoisot deleted the layers/feat/minus-layer branch May 13, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No method for -layer
2 participants