Skip to content

Conversation

@nishaq503
Copy link
Contributor

@nishaq503 nishaq503 commented Oct 30, 2023

This PR updates the Image assembler plugin to the new plugin standards.

It includes work from:

  • Antoine (@agerardin) to update the plugin to use filepattern2 and preadator
  • me to update the plugin with new pre-commit hooks and some code refactoring.

TODO:

  • One of the tests hangs. I have asked for input from Antoine on this.
  • Optionally, we want to run tests on images from MIST.
  • After passing reviews, we need to bump the version number.
  • Close the old PR.
  • After merging the docs PR on preadator, we need to update the dependency in pyproject.toml.

@sweep-ai-deprecated
Copy link

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@agerardin agerardin mentioned this pull request Nov 8, 2023
7 tasks
@nishaq503 nishaq503 closed this Dec 21, 2023
@nishaq503 nishaq503 deleted the update/image-assembler branch December 21, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant