fix(sdk): use approve procedure in reservation

Also fixed typing issues

Author: monitz87

packages/new-polymath-sdk/src/procedures/Approve.ts

@@ -2,7 +2,7 @@ import BigNumber from 'bignumber.js';
 import { Procedure } from './Procedure';
 import { types } from '@polymathnetwork/new-shared';
 
-interface Args {
+export interface Args {
   amount: BigNumber;
   spender: string;
 }

packages/new-polymath-sdk/src/procedures/CreateCheckpoint.ts

@@ -1,7 +1,7 @@
 import { Procedure } from './Procedure';
 import { types } from '@polymathnetwork/new-shared';
 
-interface Args {
+export interface Args {
   symbol: string;
 }
 

packages/new-polymath-sdk/src/procedures/CreateErc20DividendDistribution.ts

@@ -1,13 +1,14 @@
 import { Procedure } from './Procedure';
 import { TaxWithholding } from '~/types';
 import { types } from '@polymathnetwork/new-shared';
+import BigNumber from 'bignumber.js';
 
-interface Args {
+export interface Args {
   symbol: string;
   maturityDate: Date;
   expiryDate: Date;
   erc20Address: string;
-  amount: number;
+  amount: BigNumber;
   checkpointId: number;
   name: string;
   excludedAddresses?: string[];

packages/new-polymath-sdk/src/procedures/CreateEtherDividendDistribution.ts

@@ -1,12 +1,13 @@
 import { Procedure } from './Procedure';
 import { TaxWithholding } from '~/types';
 import { types } from '@polymathnetwork/new-shared';
+import BigNumber from 'bignumber.js';
 
-interface Args {
+export interface Args {
   symbol: string;
   maturityDate: Date;
   expiryDate: Date;
-  amount: number;
+  amount: BigNumber;
   checkpointId: number;
   name: string;
   excludedAddresses?: string[];

packages/new-polymath-sdk/src/procedures/CreateSecurityToken.ts

@@ -2,7 +2,7 @@ import { Procedure } from './Procedure';
 import { Approve } from '~/procedures/Approve';
 import { types } from '@polymathnetwork/new-shared';
 
-interface Args {
+export interface Args {
   name: string;
   symbol: string;
   detailsUrl?: string;

packages/new-polymath-sdk/src/procedures/EnableDividendModules.ts

@@ -2,7 +2,7 @@ import { Procedure } from './Procedure';
 import { DividendModuleTypes } from '~/LowLevel/types';
 import { types as sharedTypes } from '@polymathnetwork/new-shared';
 
-interface Args {
+export interface Args {
   symbol: string;
   storageWalletAddress: string;
   types?: DividendModuleTypes[];

packages/new-polymath-sdk/src/procedures/ReclaimFunds.ts

@@ -3,7 +3,7 @@ import { DividendModuleTypes } from '~/LowLevel/types';
 import { DividendCheckpoint } from '~/LowLevel/DividendCheckpoint';
 import { types } from '@polymathnetwork/new-shared';
 
-interface Args {
+export interface Args {
   symbol: string;
   dividendIndex: number;
   dividendType: DividendModuleTypes;

packages/new-polymath-sdk/src/procedures/ReserveSecurityToken.ts

@@ -2,7 +2,7 @@ import { Procedure } from './Procedure';
 import { Approve } from './Approve';
 import { types } from '@polymathnetwork/new-shared';
 
-interface Args {
+export interface Args {
   symbol: string;
   name: string;
 }
@@ -11,15 +11,16 @@ export class ReserveSecurityToken extends Procedure<Args> {
   public type = types.ProcedureTypes.ReserveSecurityToken;
   public async prepareTransactions() {
     const { symbol, name } = this.args;
-    const { securityTokenRegistry, currentWallet, polyToken } = this.context;
+    const { securityTokenRegistry, currentWallet } = this.context;
 
     // TODO @RafaelVidaurre: See if ticker is not already registered
 
     const fee = await securityTokenRegistry.getTickerRegistrationFee();
 
-    await this.addTransaction(polyToken.approve, {
-      tag: types.PolyTransactionTags.Approve,
-    })(securityTokenRegistry.address, fee);
+    await this.addTransaction(Approve)({
+      amount: fee,
+      spender: securityTokenRegistry.address,
+    });
 
     await this.addTransaction(securityTokenRegistry.registerTicker, {
       tag: types.PolyTransactionTags.ReserveSecurityToken,

packages/new-polymath-sdk/src/procedures/WithdrawTaxes.ts

@@ -3,7 +3,7 @@ import { DividendModuleTypes } from '~/LowLevel/types';
 import { DividendCheckpoint } from '~/LowLevel/DividendCheckpoint';
 import { types } from '@polymathnetwork/new-shared';
 
-interface Args {
+export interface Args {
   symbol: string;
   dividendIndex: number;
   dividendType: DividendModuleTypes;