Skip to content

Dividends page fixes#383

Merged
RafaelVidaurre merged 5 commits intoepic/dividendsfrom
fix/dividends-page
Feb 22, 2019
Merged

Dividends page fixes#383
RafaelVidaurre merged 5 commits intoepic/dividendsfrom
fix/dividends-page

Conversation

@monitz87
Copy link
Contributor

@monitz87 monitz87 commented Feb 21, 2019

Please make sure the following boxes are checked before submitting your Pull Request:

  • I've added this PR's link to its Asana task(s)
  • If this PR adds new code that is not going to change in the near future, it includes unit tests to cover it.

This PR:

  • Hides the checkpoint creation button if the dividends module hasn't been enabled
  • Fixes the checkpoint fetching SDK function (was throwing an error because of web3 documentation nonsense)
  • Reorders the checkpoint caching/creation logic in the state
  • Replaces hardcoded security token symbol with router param in the checkpoint list
  • Fixes the bug that caused the transaction modal to not disappear after enabling the dividends module
  • Renames Checkpoints to CheckpointList and Checkpoint to DividendList
  • Passes the downloadOwnershipList container function to the CheckpointList presenter and calls it when the button is clicked

@RafaelVidaurre RafaelVidaurre merged commit b9cb5be into epic/dividends Feb 22, 2019
@RafaelVidaurre RafaelVidaurre deleted the fix/dividends-page branch February 22, 2019 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants