timeline start/end should use global earliest and latest time #2319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miratepuffin
approved these changes
Oct 8, 2025
|
LGTM - are you planning to add the test to this PR? |
…back, not filtered time as rolling/expanding for different layers etc. should align by default
ljeub-pometry
force-pushed
the
bug/timeline_start
branch
from
f9135a8 to
333e0dd
Compare
yes, added it now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The
timeline_startandtimeline_endfallbacks for not explicitly windowed graphs were looking at the filtered earliest and latest time. This will make rolling/expanding inconsistent between different layers etc. which is not great. Additionally, computing the filtered time can be relatively expensive.Why are the changes needed?
Does this PR introduce any user-facing change? If yes is this documented?
How was this patch tested?
Are there any further changes required?