Skip to content

Don't return 500s for books containing non-ASCII fields. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Don't return 500s for books containing non-ASCII fields. #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5eb52fb
Minor typo fix in the README.
Julian Jun 7, 2023
70e2a41
Don't return 500s for books containing non-ASCII fields.
Julian Jun 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

You will need to have [Postgres](https://www.postgresql.org/) installed to run test and development databases.

Once Postgres is install, you should have access to the `psql` command.
Once Postgres is installed, you should have access to the `psql` command.

### Initialize database

Expand Down
4 changes: 2 additions & 2 deletions Test_Runner_Story.postman_collection.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -890,7 +890,7 @@
},
{
"key": "testBookAuthor",
"value": "bar",
"value": "פלוני אלמוני",
Copy link
Author

@Julian Julian Jun 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This says "John Doe" essentially FWIW)

"type": "string"
},
{
Expand All @@ -908,4 +908,4 @@
"value": ""
}
]
}
}
6 changes: 5 additions & 1 deletion src/utils/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,11 @@ export const filterObjStringsForProfanity = <T extends { [key: string]: any }>(
Object.entries(obj).forEach(([k, v]) => {
filtered[k] = v
if (typeof v === 'string') {
filtered[k] = filterProfanity(v)
try {
filtered[k] = filterProfanity(v)
} catch (err) {
console.error(`Couldn't check ${v} for profanity.`);
};
}
})
return filtered as T
Expand Down