-
Notifications
You must be signed in to change notification settings - Fork 974
auth meson: reset binary names to original #16401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 19278070070Details
💛 - Coveralls |
Member
Author
|
green. ready for review. |
miodvallat
reviewed
Nov 3, 2025
Contributor
miodvallat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the name change also be documented? Or can we afford to not mention this because so far none of the released tarballs has been usable with meson out of the box?
f63e2e4 to
1cf5b84
Compare
Member
Author
|
simplified as requested |
miodvallat
approved these changes
Nov 11, 2025
1cf5b84 to
13be298
Compare
Member
Author
|
thanks, squashed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
in draft until tests pass. Will probably squash then.
There is a lot of repetition in this patch, because there is a lot of repetition in test scripts for finding the binaries. Some refactoring seems obvious, but this PR is simple on purpose so we can backport it to
rel/auth-5.0.xChecklist
I have: