Skip to content

Conversation

@Habbie
Copy link
Member

@Habbie Habbie commented Oct 31, 2025

Short description

in draft until tests pass. Will probably squash then.

There is a lot of repetition in this patch, because there is a lot of repetition in test scripts for finding the binaries. Some refactoring seems obvious, but this PR is simple on purpose so we can backport it to rel/auth-5.0.x

Checklist

I have:

  • read the CONTRIBUTING.md document
  • read and accepted the Developer Certificate of Origin document, including the AI Policy, and added a "Signed-off-by" to my commits
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@coveralls
Copy link

coveralls commented Oct 31, 2025

Pull Request Test Coverage Report for Build 19278070070

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 37 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-0.006%) to 73.0%

Files with Coverage Reduction New Missed Lines %
pdns/misc.cc 2 61.45%
pdns/pkcs11signers.cc 2 64.51%
pdns/rcpgenerator.cc 2 90.63%
pdns/tcpreceiver.cc 2 66.84%
modules/pipebackend/coprocess.cc 3 53.91%
pdns/recursordist/recpacketcache.hh 3 89.55%
pdns/signingpipe.cc 4 84.99%
pdns/recursordist/lwres.cc 6 66.06%
pdns/recursordist/syncres.cc 6 81.18%
pdns/recursordist/test-syncres_cc1.cc 7 90.16%
Totals Coverage Status
Change from base Build 19277975675: -0.006%
Covered Lines: 127560
Relevant Lines: 164020

💛 - Coveralls

@Habbie Habbie marked this pull request as ready for review October 31, 2025 16:30
@Habbie
Copy link
Member Author

Habbie commented Oct 31, 2025

green. ready for review.

Copy link
Contributor

@miodvallat miodvallat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the name change also be documented? Or can we afford to not mention this because so far none of the released tarballs has been usable with meson out of the box?

@Habbie Habbie force-pushed the auth-meson-names-dumb-rename branch from f63e2e4 to 1cf5b84 Compare November 11, 2025 13:08
@Habbie
Copy link
Member Author

Habbie commented Nov 11, 2025

simplified as requested

@Habbie Habbie force-pushed the auth-meson-names-dumb-rename branch from 1cf5b84 to 13be298 Compare November 11, 2025 20:44
@Habbie
Copy link
Member Author

Habbie commented Nov 11, 2025

thanks, squashed

@Habbie Habbie merged commit 6e06af9 into PowerDNS:master Nov 13, 2025
91 checks passed
@Habbie Habbie deleted the auth-meson-names-dumb-rename branch November 13, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants