Skip to content

Conversation

@PaulSchulz
Copy link
Contributor

Also, removed trailing spaces in doc file.

The description of 'uF' should apply to a Farad(F) not an Ampere(A).

Also, removed trailing spaces in doc file.
DCO Remediation Commit for Paul Schulz <paul@mawsonlakes.org>

I, Paul Schulz <paul@mawsonlakes.org>, hereby add my Signed-off-by to this commit: 9eea074

Signed-off-by: Paul Schulz <paul@mawsonlakes.org>
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PaulSchulz Looks good to me; one minor nitpick. Since this PR is marked as Open, I will treat it as ready to merge after the comment is resolved.

If you would like to add some more commits to the PR, please click convert to draft so that we know it is not yet fully ready for merge

@mgovers
Copy link
Member

mgovers commented Sep 3, 2024

failing CI action https://github.com/PowerGridModel/power-grid-model-io/actions/runs/10677700397/job/29593513810?pr=272 is most likely caused by some kind of configuration issue and is not related to your PR. I will investigate and temporarily bypass if needed.

@mgovers
Copy link
Member

mgovers commented Sep 3, 2024

failing CI action https://github.com/PowerGridModel/power-grid-model-io/actions/runs/10677700397/job/29593513810?pr=272 is most likely caused by some kind of configuration issue and is not related to your PR. I will investigate and temporarily bypass if needed.

Found and being fixed in #273 . Unfortunately, that is blocking for this PR

mgovers and others added 2 commits September 3, 2024 09:28
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>

Signed-off-by: Martijn Govers <martygovers@hotmail.com>
@mgovers mgovers enabled auto-merge September 3, 2024 07:28
@mgovers mgovers added this pull request to the merge queue Sep 3, 2024
Merged via the queue into PowerGridModel:main with commit 770f21a Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants