Skip to content

Restrict pandapower to <3.0 #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 7, 2025
Merged

Restrict pandapower to <3.0 #294

merged 4 commits into from
Apr 7, 2025

Conversation

@nitbharambe
Copy link
Member

@nitbharambe nitbharambe commented Apr 4, 2025 •
edited
Loading

CI fails at #292 and #293 . We need to

  1. upgrade pandapower to 3.0
  2. remove the __array_prepare__ from MockFn before upgrade to numpy 2.0

@nitbharambe
add upper limit
7c84624 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe nitbharambe changed the title add upper limit to numpy Numpy to <2.0 Apr 4, 2025
@nitbharambe
restrict pandapower too
b5160b4 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe nitbharambe changed the title Numpy to <2.0 Restrict pandapower to <3.0 and numpy to <2.0 Apr 4, 2025
@nitbharambe nitbharambe marked this pull request as ready for review April 4, 2025 09:17
@mgovers
Copy link
Member

mgovers commented Apr 4, 2025

I did a quick experiment and this can be safely done without any impact on the repo:

remove the array_prepare from MockFn before upgrade to numpy 2.0

mgovers
mgovers reviewed Apr 4, 2025
View reviewed changes
@nitbharambe
Copy link
Member Author

nitbharambe commented Apr 4, 2025 •
edited
Loading

I did a quick experiment and this can be safely done without any impact on the repo:

remove the array_prepare from MockFn before upgrade to numpy 2.0

I wanted the CI to confirm this too. But its not possible because pandapower cannot be upgraded to 3.0 in this branch. If anything additional is found it would have to be resolved at the pandapower 3.0 upgradation then.

Lets go with what you suggest. I am fine either way

@nitbharambe
remove array prepare
949c002 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe nitbharambe changed the title Restrict pandapower to <3.0 and numpy to <2.0 Restrict pandapower to <3.0 Apr 4, 2025
@nitbharambe
revert utils change
9a833ff 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@figueroa1395
Copy link
Member

figueroa1395 commented Apr 4, 2025

Maybe worth mentioning here, also for reference, that the nightly is failing miserably (https://github.com/PowerGridModel/power-grid-model-io/actions/runs/14256774715/job/39960784060) and it is very likely related to this pandapower issue.

@mgovers mgovers added the dependencies Pull requests that update a dependency file label Apr 7, 2025
@mgovers mgovers enabled auto-merge April 7, 2025 07:34
@mgovers mgovers added this pull request to the merge queue Apr 7, 2025
Merged via the queue into main with commit 2753d05 Apr 7, 2025
23 checks passed
@mgovers mgovers deleted the feautre/restrict-numpy-2.0 branch April 7, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgovers mgovers mgovers approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nitbharambe @mgovers @figueroa1395