-
Notifications
You must be signed in to change notification settings - Fork 12
Github release workflow fix: Rename job call #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
|
Maybe a good idea is to first just fix the current issue, as it was initially done in 54e3dbd, and make sure that works. Then do the homogenization in a separate PR. Even though it is a "simple" PR, it is a dangerous one, and if we break something during homogenization, then it may be harder to track. In addition, if you want to test things before merging, the Test PyPI repo for pgm-io is still alive: https://test.pypi.org/project/power-grid-model-io/. Just follow the comments in the publish job to see how to use it. |
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
That was the original intention. However the fix requires homogenization (or some more steps more than renaming). Hence the upcoming commits include homogenization too. |
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess everything works except:
- the required status check.
- Test the upload by publishing to TestPyPI (https://test.pypi.org/legacy/) cfr. the inline comments on the upload action
Co-authored-by: Martijn Govers <martijn.govers@alliander.com> Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
|
Publishing has now been tested and works as expected: https://test.pypi.org/project/power-grid-model-io/#history. Manual CI trigger (successful): https://github.com/PowerGridModel/power-grid-model-io/actions/runs/15303577121 One more TODO, is to clean up the "testing" pre-releases that were generated to keep it clean. This was also done before. |
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com> Signed-off-by: Martijn Govers <martygovers@hotmail.com>
|
|
|
||
| jobs: | ||
| main: | ||
| build-test-release: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should re-add building sonar in the nightly @nitbharambe , also in PGM



Fixes:
publishing post v1.2.123
Changes proposed in this PR include:
Checks