Skip to content

Conversation

@nitbharambe
Copy link
Member

@nitbharambe nitbharambe commented May 27, 2025

Fixes:
publishing post v1.2.123

Changes proposed in this PR include:

  • Rename call of build-test-release
  • Homogenize workflows in PGM and PGM-IO to make life easier

Checks

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@figueroa1395
Copy link
Member

Maybe a good idea is to first just fix the current issue, as it was initially done in 54e3dbd, and make sure that works. Then do the homogenization in a separate PR. Even though it is a "simple" PR, it is a dangerous one, and if we break something during homogenization, then it may be harder to track.

In addition, if you want to test things before merging, the Test PyPI repo for pgm-io is still alive: https://test.pypi.org/project/power-grid-model-io/. Just follow the comments in the publish job to see how to use it.

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
Copy link
Member Author

nitbharambe commented May 28, 2025

Maybe a good idea is to first just fix the current issue, as it was initially done in 54e3dbd, and make sure that works. Then do the homogenization in a separate PR. Even though it is a "simple" PR, it is a dangerous one, and if we break something during homogenization, then it may be harder to track.

In addition, if you want to test things before merging, the Test PyPI repo for pgm-io is still alive: https://test.pypi.org/project/power-grid-model-io/. Just follow the comments in the publish job to see how to use it.

That was the original intention. However the fix requires homogenization (or some more steps more than renaming). Hence the upcoming commits include homogenization too.

Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess everything works except:

  • the required status check.
  • Test the upload by publishing to TestPyPI (https://test.pypi.org/legacy/) cfr. the inline comments on the upload action

nitbharambe and others added 2 commits May 28, 2025 11:38
Co-authored-by: Martijn Govers <martijn.govers@alliander.com>
Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@figueroa1395
Copy link
Member

figueroa1395 commented May 28, 2025

Publishing has now been tested and works as expected: https://test.pypi.org/project/power-grid-model-io/#history.

Manual CI trigger (successful): https://github.com/PowerGridModel/power-grid-model-io/actions/runs/15303577121

One more TODO, is to clean up the "testing" pre-releases that were generated to keep it clean. This was also done before.

@nitbharambe nitbharambe marked this pull request as ready for review May 28, 2025 19:37
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>

Signed-off-by: Martijn Govers <martygovers@hotmail.com>
@sonarqubecloud
Copy link

@nitbharambe nitbharambe added this pull request to the merge queue May 30, 2025
@nitbharambe nitbharambe removed this pull request from the merge queue due to a manual request May 30, 2025
@nitbharambe nitbharambe added this pull request to the merge queue May 30, 2025
Merged via the queue into main with commit 12527b3 May 30, 2025
31 checks passed
@nitbharambe nitbharambe deleted the fix/github-release-workflow-renaming branch May 30, 2025 07:16

jobs:
main:
build-test-release:
Copy link
Member

@mgovers mgovers May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should re-add building sonar in the nightly @nitbharambe , also in PGM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants