Update pandapower requirement from <3.1,>2.11.1 to >2.11.1 #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the requirements on [pandapower](https://github.com/e2nIEE/pandapower) to permit the latest version. - [Release notes](https://github.com/e2nIEE/pandapower/releases) - [Changelog](https://github.com/e2nIEE/pandapower/blob/develop/CHANGELOG.rst) - [Commits](e2nIEE/pandapower@v2.12.0...v3.1.1) --- updated-dependencies: - dependency-name: pandapower dependency-version: 3.1.1 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
Member
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the pandapower dependency bounds to allow newer 3.x releases and adjusts test imports and CI steps accordingly.
- Removed conditional import skips so tests now assume pandapower is installed via dev extras.
- Updated
pyproject.tomland workflow to simplify pandapower version specifiers. - Dropped the
# pragma: no coveronPandaPowerConverterto include it in coverage.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/validation/converters/test_pandapower_converter_input.py | Removed pytest.importorskip wrapper so tests always import pandapower. |
| tests/unit/converters/test_pandapower_converter_input.py | Added direct import pandapower as pp and removed skip logic. |
| src/power_grid_model_io/converters/pandapower_converter.py | Removed # pragma: no cover annotation on PandaPowerConverter class. |
| pyproject.toml | Changed optional-dev and examples extras to pandapower>2.11.1 (dropped upper bounds). |
| .github/workflows/build-test-release.yml | Simplified wheel installation steps by removing Python-3.13-specific dev-bare logic. |
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
|
mgovers
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the pandapower requirement to allow the latest 3.x release and simplifies related test skips and CI installation steps.
- Remove version upper bounds for pandapower in
pyproject.tomland examples. - Replace
pytest.importorskipwith direct imports in tests. - Simplify wheel installation logic in the GitHub Actions workflow.
- Remove coverage exclusion on
PandaPowerConverter.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/validation/converters/test_pandapower_converter_input.py | Removed pytest.importorskip; tests now assume pandapower is installed. |
| tests/unit/converters/test_pandapower_converter_input.py | Dropped importorskip, added import pandapower as pp. |
| src/power_grid_model_io/converters/pandapower_converter.py | Removed # pragma: no cover from the PandaPowerConverter class. |
| pyproject.toml | Updated dev and examples dependencies to pandapower>2.11.1 (no upper bound). |
| .github/workflows/build-test-release.yml | Unified wheel installation step for all Python versions. |
Comments suppressed due to low confidence (2)
src/power_grid_model_io/converters/pandapower_converter.py:38
- The removal of the '# pragma: no cover' annotation means this class is now included in coverage reports; ensure there are corresponding tests covering its functionality or re-add a targeted coverage exclusion.
class PandaPowerConverter(BaseConverter[PandaPowerData]):
pyproject.toml:48
- [nitpick] Specifying an upper bound for the pandapower dependency can help prevent unintended breakages with future major releases; consider adding '<4.0' (or similar) to the version constraint.
"pandapower>2.11.1",
6 tasks
nitbharambe
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #306
Updates the requirements on pandapower to permit the latest version.
Release notes
Sourced from pandapower's releases.
Commits
5e2a0aaMerge branch 'hotfix/digital_attestation_url'5c06f9fbump versione4e9db7Documentation stated something different, but I had to change the url again b...8d86913Merge branch 'release/v3.1.0'a32cea6bump versionf9802d2Merge pull request #2618 from e2nIEE/feature/automatic_attestation4290a2dMerge branch 'develop' into feature/automatic_attestation164e561updated authors file96285f2test file already existed therefore, added a skipping feature for testing.7e44952enbling debugginDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)