Corrections of enum in PF assignment #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
Jerry-Jinfeng-Guo
previously approved these changes
May 15, 2025
Member
There was a problem hiding this comment.
Values in this file differ quite a bit from previously, anything to worry there?
Member
There was a problem hiding this comment.
the values were generated randomly (random load profile). See e.g. https://github.com/PowerGridModel/power-grid-model-workshop/pull/30/files#diff-6b06c3a80cc8ef2e343f9d271e1b949e54322701fb39fcc4922a9543213329a4R739
The execution times are device, OS and runtime-dependent and do not differ enough to require further investigation.
Jerry-Jinfeng-Guo
dismissed
their stale review
Pending on response on the notebook data differences
Member
|
@nitbharambe this was merged without approval. I will enable branch protection for this repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enums related changes didn't render solutions properly. Hence this fix