Current sensor: remove experimental flag for ILSE #1007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Member
|
LGTM. what still needs to happen before it is ready for review/merge? |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Removes the experimental flag for current sensors in Iterative Linear State Estimation (ILSE) across API, core implementation, tests, and documentation.
- C++ core: only throw for Newton-Raphson when current sensors are present; ILSE no longer requires an experimental flag
- Tests: drop
experimental_featuresargument and update assertions to expect no throws for ILSE - Docs: remove warnings that ILSE support is experimental in component and calculation guides
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/test_error_handling.py | Removed experimental_features parameter from _calculate_state_estimation calls |
| tests/native_api_tests/test_api_model.cpp | Renamed subcase, changed ILSE assertions to CHECK_NOTHROW when disabled |
| power_grid_model_c/power_grid_model/include/power_grid_model/main_model_impl.hpp | Simplified check_no_experimental_features_used to only throw on Newton-Raphson |
| docs/user_manual/components.md | Deleted experimental warning around current sensors |
| docs/user_manual/calculations.md | Removed note marking ILSE with current sensors as experimental |
Comments suppressed due to low confidence (2)
power_grid_model_c/power_grid_model/include/power_grid_model/main_model_impl.hpp:808
- [nitpick] Consider extracting the exception message into a shared constant to ensure consistency and avoid duplication between code and tests.
throw ExperimentalFeature{"Newton-Raphson state estimation is not implemented for current sensors"};
tests/unit/test_error_handling.py:424
- Add a test case to verify that ILSE with current sensors no longer raises an ExperimentalFeature exception, ensuring the behavior change is covered.
model._calculate_state_estimation(decode_error=True)
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
figueroa1395
reviewed
Jun 3, 2025
Member
figueroa1395
left a comment
figueroa1395
left a comment
There was a problem hiding this comment.
LGTM, just some minor comments.
power_grid_model_c/power_grid_model/include/power_grid_model/main_model_impl.hpp
Show resolved
Hide resolved
mgovers
reviewed
Jun 4, 2025
Member
There was a problem hiding this comment.
also to be updated to reflect that iterative_linear no longer requires experimental_features to be enabled:
-
tests\data\state_estimation\current-sensor\global-current-sensor\params.json -
tests\data\state_estimation\current-sensor\local-current-sensor\params.json
Signed-off-by: Martijn Govers <Martijn.Govers@Alliander.com>
mgovers
approved these changes
Jun 4, 2025
|
nitbharambe
approved these changes
Jun 4, 2025
figueroa1395
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The experimental flag is removed for current sensor in ILSE: