Add mypy to pre-commit (and introduce data_types.py) #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bram Stoeller <bram.stoeller@alliander.com>
Signed-off-by: Bram Stoeller <bram.stoeller@alliander.com>
petersalemink95
requested changes
Jul 28, 2022
Signed-off-by: Bram Stoeller <bram.stoeller@alliander.com>
Signed-off-by: Bram Stoeller <bram.stoeller@alliander.com>
petersalemink95
previously approved these changes
Jul 28, 2022
Signed-off-by: Bram Stoeller <bram.stoeller@alliander.com>
…grid-model into feature/mypy
Signed-off-by: Bram Stoeller <bram.stoeller@alliander.com>
Signed-off-by: Bram Stoeller <bram.stoeller@alliander.com>
bramstoeller
force-pushed
the
feature/mypy
branch
from
cf6072f to
d531070
Compare
Signed-off-by: Bram Stoeller <bram.stoeller@alliander.com>
Member
|
@bramstoeller also put all the checks in the pipeline. modify the name to a more meaningful name of file, name of workflow and jobs |
Signed-off-by: Bram Stoeller <bram.stoeller@alliander.com>
Signed-off-by: Bram Stoeller <bram.stoeller@alliander.com>
Signed-off-by: Bram Stoeller <bram.stoeller@alliander.com>
Signed-off-by: Bram Stoeller <bram.stoeller@alliander.com>
Signed-off-by: Bram Stoeller <bram.stoeller@alliander.com>
Signed-off-by: Bram Stoeller <bram.stoeller@alliander.com>
Signed-off-by: Bram Stoeller <bram.stoeller@alliander.com>
Signed-off-by: Bram Stoeller <bram.stoeller@alliander.com>
Signed-off-by: Bram Stoeller <bram.stoeller@alliander.com>
Signed-off-by: Bram Stoeller <bram.stoeller@alliander.com>
Signed-off-by: Bram Stoeller <bram.stoeller@alliander.com>
Signed-off-by: Bram Stoeller <bram.stoeller@alliander.com>
Signed-off-by: Bram Stoeller <bram.stoeller@alliander.com>
Signed-off-by: Bram Stoeller <bram.stoeller@alliander.com>
Signed-off-by: Bram Stoeller <bram.stoeller@alliander.com>
TonyXiang8787
previously approved these changes
Aug 3, 2022
Signed-off-by: Bram Stoeller <bram.stoeller@alliander.com>
This reverts commit cf584f8. Signed-off-by: Bram Stoeller <bram.stoeller@alliander.com>
Signed-off-by: Bram Stoeller <bram.stoeller@alliander.com>
Signed-off-by: Bram Stoeller <bram.stoeller@alliander.com>
Signed-off-by: Bram Stoeller <bram.stoeller@alliander.com>
Signed-off-by: Bram Stoeller <bram.stoeller@alliander.com>
Signed-off-by: Bram Stoeller <bram.stoeller@alliander.com>
Signed-off-by: Bram Stoeller <bram.stoeller@alliander.com>
Signed-off-by: Bram Stoeller <bram.stoeller@alliander.com>
Signed-off-by: Bram Stoeller <bram.stoeller@alliander.com>
TonyXiang8787
approved these changes
Aug 4, 2022
TonyXiang8787
requested changes
Aug 4, 2022
Member
TonyXiang8787
left a comment
TonyXiang8787
left a comment
There was a problem hiding this comment.
In the README there is a badge for format check.
Now you changed the name of the workflow. Maybe you need to modify the badge.
Signed-off-by: Bram Stoeller <bram.stoeller@alliander.com>
TonyXiang8787
approved these changes
Aug 4, 2022
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When applying mypy, I noticed that we had some errors in our type hinting. I got confused in the forrest of Lists, Dicts, etcetera, so in an attempt to make the data structures a bit more understandable, I've introduced type aliases in data_types.py. I'm not sure this is better or even more readable, so please be critical in your review!