Skip to content

Three winding transformer #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 93 commits into from
Aug 25, 2022
Merged

Three winding transformer #18

merged 93 commits into from
Aug 25, 2022

Conversation

@TonyXiang8787
Copy link
Member

@TonyXiang8787 TonyXiang8787 commented Feb 10, 2022

No description provided.

@TonyXiang8787
change inheritance diagram
af3b131 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787
add branch3
606a9cb 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787
finish branch and enumeration
7b55dec 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787
begin transformer
55cf002 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787
transformer attribute
d738924 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787
add example graph
4bf5cda 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787 TonyXiang8787 linked an issue May 29, 2022 that may be closed by this pull request
[FEATURE] Add support for Three Winding Transformers #12
Closed
5 tasks
@TonyXiang8787 TonyXiang8787 changed the base branch from main to release/1.4 June 17, 2022 11:12
nitbharambe and others added 22 commits July 10, 2022 16:41
@nitbharambe
Merge branch 'release/1.4' into feature/3-winding-transformer
c20bec7
@nitbharambe
fix conflict merge
41f9cb6 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@petersalemink95
add branch3 to MeasuredTerminalType enum
624c64f 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
Brach3 class with Branch3Input
6890794 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
Branch3Update
850645b 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
Branch3Output
00d5a85 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
branch3 component type
7fb3483 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
Branch3 constructor
170d416 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
ThreeWindingTransformerInput
5104d47 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
TreeWindingTrafo update
6e51648 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
3wt base constructor
78e201e 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
Merge branch 'release/1.4' into feature/3-winding-transformer
5c2f234
@petersalemink95
z_grounding
756a958 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
base current
8cf2609 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
update() Branch3
f7eb546 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
fix Transformer update() bug + unit test
e945ebe 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
ThreeWindingTransformer update()
e88873f 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
base_i getter
ae09439 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
convert 3wt to 3 2wt
d0a7259 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
remove clock_23
77e3893 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
fix compiler errors
d117b86 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
@petersalemink95
[skip ci] half of implementation in main_model
448c057 
Signed-off-by: Peter Salemink <peter.salemink@alliander.com>
nitbharambe and others added 24 commits August 18, 2022 16:00
@nitbharambe
complete validator test
d9836ce 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
add xfails and enum
1e6eab6 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
fix enum mistake
eb6a68a 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
move validator test
12d6286 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
three wdg case input
6564a8b 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
fix winding bug
623d4ee 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
add params
5ecd919 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@TonyXiang8787
add license, reproduce error
63401eb 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787
add version license
23a14de 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787
fix issue by winding type
8933747 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@nitbharambe
add unit test for dynyn
747f000 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
split validator, reformat
b5e465a 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@TonyXiang8787
retest trafo pandapower
331d2e4 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787
fix batch test case
a854382 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787
5 empty result set
9f11dc6 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787
pylint ignore
18b9724 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787
run isort
2c39f50 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787
fix unit test on validation
1171493 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787
run black
9e01cd8 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787
Merge branch 'release/1.4' into feature/3-winding-transformer
6acbfb4
@nitbharambe
fix enum for branch3 in validator
2457772 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@TonyXiang8787
formatting
dc2e2e5 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@nitbharambe
add validation test case
f597681 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@TonyXiang8787
add const
b14cc30 
Signed-off-by: Tony Xiang <tony.xiang@alliander.com>
@TonyXiang8787 TonyXiang8787 marked this pull request as ready for review August 25, 2022 09:03
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 43 Code Smells

98.6% 98.6% Coverage
0.0% 0.0% Duplication

@TonyXiang8787 TonyXiang8787 merged commit 5a58f5d into release/1.4 Aug 25, 2022
@TonyXiang8787 TonyXiang8787 deleted the feature/3-winding-transformer branch August 25, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nitbharambe nitbharambe nitbharambe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE] Add support for Three Winding Transformers

4 participants

@TonyXiang8787 @nitbharambe @petersalemink95