Skip to content

Chore/project ids cleanup#27

Merged
anomit merged 5 commits intoonchain_poolerfrom
chore/project_ids_cleanup
Jun 7, 2023
Merged

Chore/project ids cleanup#27
anomit merged 5 commits intoonchain_poolerfrom
chore/project_ids_cleanup

Conversation

@xadahiya
Copy link
Contributor

@xadahiya xadahiya commented Jun 7, 2023

Checklist

  • My branch is up-to-date with the upstream/develop branch.
  • I have tested everything and ensured compatibility with Python 3.8.0 and above.
  • I have successfully passed pre-commit checks for my changes.

Current behavior

Currently, generated project IDs are utilizing the UNISWAPV2-ph15-prod project namespace, resulting in project IDs that contain uniswap twice, such as uniswap_pairContract_pair_total_reserves:0xa478c2975ab1ea89e8196811f51a7b7ade33eb11:UNISWAPV2-ph15-prod.

New expected behavior

The updated code aims to improve the readability and clarity of generated project IDs. Additionally, the ph15-prod component is no longer relevant. The new project ID format addresses the aforementioned issues. The IDs will now follow a format similar to the example below:
aggregate_pairContract_24h_trade_volume:0xa478c2975ab1ea89e8196811f51a7b7ade33eb11:UNISWAPV2

Deployment Instructions

To deploy the changes, follow these steps:

  1. Regenerate the projects.json and aggregator.json files.
  2. Restart the services.

@xadahiya xadahiya requested a review from anomit June 7, 2023 13:21
Copy link
Member

@anomit anomit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anomit anomit merged commit e7d720d into onchain_pooler Jun 7, 2023
@SwaroopH SwaroopH deleted the chore/project_ids_cleanup branch July 27, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants