Skip to content

Conversation

@NoriZC
Copy link
Contributor

@NoriZC NoriZC commented Nov 1, 2024

PR Summary

This PR did:

  • Remove id for correlation from Exception. Although The Exception can be constructed with CopilotResponse, it is always set as null in current code base (which also caused the TopicName not collected in the Telemetry). As we need user consent to save the IDs and we are not asking for user consent when an error occurs, I think it should be good to just remove the response parameter.
  • Make the EventType clearer to easier identify AIShell Exceptions from all exceptions logged, which would make query easier. Because we are sharing 1 app inisghts resource between AIShell and AzPS/ AzCLI Endpoint. (Please feel free to raise any other suggestions, for example shall we create a new column for this? Like {EventType: "Exceprion", ExceptionFrom: "AIShell"}.)

PR Context

Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@daxian-dbw daxian-dbw merged commit 8bdf79c into PowerShell:main Nov 1, 2024
4 checks passed
@NoriZC NoriZC deleted the telemetry-exception branch November 1, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants