Skip to content

Update to use template files#229

Merged
johlju merged 1 commit intodsccommunity:devfrom
johlju:add-template
Sep 25, 2018
Merged

Update to use template files#229
johlju merged 1 commit intodsccommunity:devfrom
johlju:add-template

Conversation

@johlju
Copy link
Copy Markdown
Member

@johlju johlju commented Sep 22, 2018

Pull Request (PR) description

  • Update appveyor.yml to use the default template.
  • Added default template files .gitattributes, and .gitignore, and
    .vscode folder.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the README.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Sep 22, 2018
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #229 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #229   +/-   ##
===================================
  Coverage    82%    82%           
===================================
  Files        15     15           
  Lines      1333   1333           
  Branches     10     10           
===================================
  Hits       1106   1106           
  Misses      217    217           
  Partials     10     10

Copy link
Copy Markdown
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju merged commit d979c54 into dsccommunity:dev Sep 25, 2018
@johlju johlju deleted the add-template branch September 25, 2018 13:06
@johlju johlju removed the needs review The pull request needs a code review. label Sep 25, 2018
johlju added a commit to johlju/ActiveDirectoryDsc that referenced this pull request Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants