Skip to content

Update README.md#449

Merged
johlju merged 1 commit intodevfrom
johlju-patch-1
Jul 27, 2019
Merged

Update README.md#449
johlju merged 1 commit intodevfrom
johlju-patch-1

Conversation

@johlju
Copy link
Copy Markdown
Member

@johlju johlju commented Jul 27, 2019

Pull Request (PR) description

  • Add new AppVeyor status badge token

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in resource directory README.md.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

- Add new AppVeyor status badge token
@johlju johlju added the needs review The pull request needs a code review. label Jul 27, 2019
Copy link
Copy Markdown
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju added ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. and removed needs review The pull request needs a code review. labels Jul 27, 2019
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #449 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #449   +/-   ##
===================================
  Coverage    98%    98%           
===================================
  Files        20     20           
  Lines      2704   2704           
  Branches     10     10           
===================================
  Hits       2651   2651           
  Misses       43     43           
  Partials     10     10

@johlju johlju merged commit e2b3ce1 into dev Jul 27, 2019
@johlju johlju deleted the johlju-patch-1 branch July 27, 2019 13:44
@johlju johlju removed the ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. label Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants