Skip to content

ActiveDirectoryDsc: Split tests in different AppVeyor jobs#479

Merged
johlju merged 30 commits intodsccommunity:devfrom
johlju:fix-issue-437
Aug 10, 2019
Merged

ActiveDirectoryDsc: Split tests in different AppVeyor jobs#479
johlju merged 30 commits intodsccommunity:devfrom
johlju:fix-issue-437

Conversation

@johlju
Copy link
Copy Markdown
Member

@johlju johlju commented Aug 9, 2019

Pull Request (PR) description

  • Changes to ActiveDirectoryDsc
    • Split the meta tests and the unit and integration tests in different AppVeyor
      jobs (issue ActiveDirectoryDsc: Split meta tests and init tests in different AppVeyor jobs #437).
    • Fixed all stub cmdlets and unit tests so the unit test can be run locally
      without having the ActiveDirectory module installed on the computer.
      This will also be reflected in the AppVeyor build worker where there
      will no longer be an ActiveDirectory module installed. This is
      to make sure that if the unit tests work locally they should also work
      in the CI pipeline.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section in the CHANGELOG.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Resource documentation added/updated in resource directory README.md.
  • Resource parameter descriptions added/updated in schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Conceptual help topic added/updated (cultureFolder\about_ResourceName.help.txt).
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Resource Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

@johlju johlju added the needs review The pull request needs a code review. label Aug 9, 2019
@codecov-io
Copy link
Copy Markdown

codecov-io commented Aug 9, 2019

Codecov Report

Merging #479 into dev will increase coverage by <1%.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff          @@
##            dev   #479    +/-   ##
====================================
+ Coverage    98%    98%   +<1%     
====================================
  Files        23     23            
  Lines      3007   3009     +2     
  Branches     10     10            
====================================
+ Hits       2958   2960     +2     
  Misses       39     39            
  Partials     10     10

Copy link
Copy Markdown
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 33 of 33 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions


appveyor.yml, line 22 at r1 (raw file):

Import-Module "

-Name


appveyor.yml, line 59 at r1 (raw file):

#Add-WindowsFeature RSAT-AD-PowerShell

Remove commented code


Tests/Unit/Stubs/Microsoft.ActiveDirectory.Management.cs, line 117 at r1 (raw file):

// Add-ADCommonGroupMember might need DistingueshedName property and ToString() method

Remove comment

Copy link
Copy Markdown
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 31 of 33 files reviewed, all discussions resolved (waiting on @johlju)


appveyor.yml, line 22 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…
Import-Module "

-Name

Done


appveyor.yml, line 59 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…
#Add-WindowsFeature RSAT-AD-PowerShell

Remove commented code

Done


Tests/Unit/Stubs/Microsoft.ActiveDirectory.Management.cs, line 117 at r1 (raw file):

Previously, johlju (Johan Ljunggren) wrote…
// Add-ADCommonGroupMember might need DistingueshedName property and ToString() method

Remove comment

Done

Copy link
Copy Markdown
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@johlju johlju added ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. and removed needs review The pull request needs a code review. labels Aug 10, 2019
@johlju johlju merged commit fd3a949 into dsccommunity:dev Aug 10, 2019
@johlju johlju deleted the fix-issue-437 branch August 10, 2019 06:24
@johlju johlju removed the ready for merge The pull request was approved by the community and is ready to be merged by a maintainer. label Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ActiveDirectoryDsc: Split meta tests and init tests in different AppVeyor jobs

2 participants