ActiveDirectoryDsc: Split tests in different AppVeyor jobs#479
ActiveDirectoryDsc: Split tests in different AppVeyor jobs#479johlju merged 30 commits intodsccommunity:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #479 +/- ##
====================================
+ Coverage 98% 98% +<1%
====================================
Files 23 23
Lines 3007 3009 +2
Branches 10 10
====================================
+ Hits 2958 2960 +2
Misses 39 39
Partials 10 10 |
johlju
left a comment
There was a problem hiding this comment.
Reviewed 33 of 33 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions
appveyor.yml, line 22 at r1 (raw file):
Import-Module "
-Name
appveyor.yml, line 59 at r1 (raw file):
#Add-WindowsFeature RSAT-AD-PowerShell
Remove commented code
Tests/Unit/Stubs/Microsoft.ActiveDirectory.Management.cs, line 117 at r1 (raw file):
// Add-ADCommonGroupMember might need DistingueshedName property and ToString() method
Remove comment
johlju
left a comment
There was a problem hiding this comment.
Reviewable status: 31 of 33 files reviewed, all discussions resolved (waiting on @johlju)
appveyor.yml, line 22 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Import-Module "
-Name
Done
appveyor.yml, line 59 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
#Add-WindowsFeature RSAT-AD-PowerShellRemove commented code
Done
Tests/Unit/Stubs/Microsoft.ActiveDirectory.Management.cs, line 117 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
// Add-ADCommonGroupMember might need DistingueshedName property and ToString() methodRemove comment
Done
johlju
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
Pull Request (PR) description
jobs (issue ActiveDirectoryDsc: Split meta tests and init tests in different AppVeyor jobs #437).
without having the ActiveDirectory module installed on the computer.
This will also be reflected in the AppVeyor build worker where there
will no longer be an ActiveDirectory module installed. This is
to make sure that if the unit tests work locally they should also work
in the CI pipeline.
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is