ActiveDirectoryDsc: Add stubs generated by Indented.StubCommand#483
Merged
johlju merged 5 commits intodsccommunity:devfrom Aug 21, 2019
Merged
ActiveDirectoryDsc: Add stubs generated by Indented.StubCommand#483johlju merged 5 commits intodsccommunity:devfrom
johlju merged 5 commits intodsccommunity:devfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #483 +/- ##
===================================
Coverage 98% 98%
===================================
Files 23 23
Lines 3050 3050
Branches 10 10
===================================
Hits 3008 3008
Misses 32 32
Partials 10 10 |
Member
Author
|
Waiting for the proposed PR indented-automation/Indented.StubCommand#21 to be merged since that is a prerequisites for this change. |
c6e6387 to
8d17f0b
Compare
- Added stubs for the modules ActiveDirectory and ADDSDeployment to be used with unit tests.
johlju
commented
Aug 21, 2019
Member
Author
johlju
left a comment
There was a problem hiding this comment.
Reviewed 28 of 28 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
The new stubs are based on the modules ActiveDirectory and ADDSDeployment
in Windows Server 2019. The stubs are generated using the PowerShell
module Indented.StubCommand. Instructions how to generate stubs
(for example for a new operating system) has been added to the README.md
in the
Tests/Unit/Stubsfolder (issue #245).the new stub modules.
Test-ADReplicationSiteto make the parameterCredentialmandatory.This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is